sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

Added check with -xp to get_level #357

Merged
edraft merged 3 commits from fix_get_level_with_negative_xp into support 2023-09-10 22:23:34 +02:00
Conversation 0 Commits 3 Files Changed 1 +3
edraft commented 2023-09-10 11:07:56 +02:00
Owner
Copy Link
No description provided.
edraft added 1 commit 2023-09-10 11:07:57 +02:00
edraft added 1 commit 2023-09-10 11:14:15 +02:00
Ebola-Chan requested changes 2023-09-10 14:45:17 +02:00
kdb-bot/src/modules/level/service/level_service.py Outdated
@ -41,2 +41,4 @@
def get_level(self, user: User) -> Level:
levels_by_server = self._levels.get_levels_by_server_id(user.server.id)
if user.xp < 0:
levels_by_server.order_by(lambda l: l.min_xp).first()
Ebola-Chan commented 2023-09-10 14:45:15 +02:00
Contributor
Copy Link

Ich meine hier fehlt ein Return.

return levels_by_server.order_by(lambda l: l.min_xp).first()
Ich meine hier fehlt ein Return. ```python return levels_by_server.order_by(lambda l: l.min_xp).first() ````
edraft commented 2023-09-10 18:21:15 +02:00
Author
Owner
Copy Link

Dem ist auch so

Dem ist auch so
edraft added 1 commit 2023-09-10 18:21:34 +02:00
Ebola-Chan approved these changes 2023-09-10 19:30:15 +02:00
edraft merged commit dca939f025 into support 2023-09-10 22:23:34 +02:00
edraft deleted branch fix_get_level_with_negative_xp 2023-09-10 22:23:34 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Ebola-Chan
Labels
Clear labels   
MVP

   
web-interface
  
bug

Something is not working

  
bugfix

Solution of a problem

  
cli

Changes for command line interface

  
discussion

Something needs to be discussed

  
documentation

Indicates a need for improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
expense
high

  
expense
low

  
expense
medium

  
expense
very-high

  
help wanted

Need some help

  
improvement

Improvement of a feature

  
invalid

Something is wrong

  
priority
blocker

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
refactoring

Code need some refactoring

  
release

Create a release

  
story

New feature

  
wontfix

This won't be fixed

No Label
MVP
web-interface
bug
bugfix
cli
discussion
documentation
duplicate
expense
high
expense
low
expense
medium
expense
very-high
help wanted
improvement
invalid
priority
blocker
priority
high
priority
low
priority
medium
question
refactoring
release
story
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#357
No description provided.
Delete Branch "fix_get_level_with_negative_xp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?