sh-edraft.de/sh_discord_bot
2
1
Fork 1
Code Issues 26 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

Added logic to check if user is allowed to see requested data #89 #197

Merged
edraft merged 2 commits from #89 into 1.0.0 2023-02-12 20:35:55 +01:00
Conversation 2 Commits 2 Files Changed 15 +199 -113
edraft commented 2023-02-11 12:55:33 +01:00
Owner
Copy Link

#89

#89
edraft added this to the Sprint 1.0.0 milestone 2023-02-11 12:55:33 +01:00
edraft self-assigned this 2023-02-11 12:55:33 +01:00
edraft added this to the Sprint 1.0.0 project 2023-02-11 12:55:40 +01:00
edraft requested review from Ebola-Chan 2023-02-11 12:55:44 +01:00
edraft force-pushed #89 from 179ea6109d to dd64435c65 2023-02-11 13:12:00 +01:00 Compare
Ebola-Chan approved these changes 2023-02-12 20:27:54 +01:00
kdb-bot/src/bot_graphql/abc/query_abc.py Outdated
@@ -35,0 +52,4 @@
if user == "system" or user.auth_role == AuthRoleEnum.admin:
return self._resolve_collection(collection, *args, **kwargs)
for x in collection:
Ebola-Chan commented 2023-02-12 20:12:51 +01:00
Contributor
Copy Link
for x in collection:
    if not self._can_user_see_element(user, x):
        return List()

Sobald ein Element in der Collection von einem User nicht gesehen werden darf, wird die ganze Collection verworfen?

```python for x in collection: if not self._can_user_see_element(user, x): return List() ``` Sobald ein Element in der Collection von einem User nicht gesehen werden darf, wird die ganze Collection verworfen?
edraft marked this conversation as resolved
edraft added 1 commit 2023-02-12 20:33:31 +01:00
Fixed collection building #89 60990db88d
Ebola-Chan approved these changes 2023-02-12 20:35:23 +01:00
edraft merged commit 898e27550e into 1.0.0 2023-02-12 20:35:55 +01:00
edraft deleted branch #89 2023-02-12 20:35:55 +01:00
edraft removed this from the Sprint 1.0.0 milestone 2023-02-13 10:23:32 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Ebola-Chan
Labels
Clear labels
MVP
web-interface
bug
Something is not working
bugfix
Solution of a problem
cli
Changes for command line interface
discussion
Something needs to be discussed
documentation
Indicates a need for improvements or additions to documentation
duplicate
This issue or pull request already exists
expense
high
expense
low
expense
medium
expense
very-high
help wanted
Need some help
improvement
Improvement of a feature
invalid
Something is wrong
priority
blocker
priority
high
priority
low
priority
medium
question
More information is needed
refactoring
Code need some refactoring
release
Create a release
story
New feature
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Sprint 1.0.0
Assignees
Clear assignees
ci edraft edraft-dev
No Assignees edraft
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#197
No description provided.
Delete Branch "#89"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?