sh-edraft.de/sh_discord_bot
2
1
Fork 1
Code Issues 26 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

Ontime berechnung zentralisieren #166 #172

Merged
edraft merged 5 commits from #166 into 0.3.1 2023-01-13 22:14:58 +01:00
Conversation 2 Commits 5 Files Changed 6 +70 -25
edraft commented 2023-01-11 17:21:30 +01:00
Owner
Copy Link

#166

#166
edraft added this to the Patch 0.3.1 milestone 2023-01-11 17:21:30 +01:00
edraft self-assigned this 2023-01-11 17:21:30 +01:00
edraft requested review from Ebola-Chan 2023-01-11 17:21:39 +01:00
edraft added this to the Patch 0.3.1 project 2023-01-11 17:21:41 +01:00
Ebola-Chan approved these changes 2023-01-12 01:33:55 +01:00
kdb-bot/src/bot_core/service/client_utils_service.py Outdated
@@ -82,2 +86,3 @@
if not result:
await self._message_service.send_ctx_msg(ctx, self._t.transform('common.errors.bot_not_ready_yet'), without_tracking=True)
await self._message_service.send_ctx_msg(ctx, self._t.transform('common.errors.bot_not_ready_yet'),
without_tracking=True)
Ebola-Chan commented 2023-01-12 01:26:02 +01:00
Contributor
Copy Link

Hier hat PyCharm reingegretscht in der Formatierung.

await self._message_service.send_ctx_msg(ctx, self._t.transform('common.errors.bot_not_ready_yet'),
                                         without_tracking=True)
Hier hat PyCharm reingegretscht in der Formatierung. ``` await self._message_service.send_ctx_msg(ctx, self._t.transform('common.errors.bot_not_ready_yet'), without_tracking=True) ```
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -171,2 +168,3 @@
else:
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform('modules.base.user.error.atr_not_found').format(atr))
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(
'modules.base.user.error.atr_not_found').format(atr))
Ebola-Chan commented 2023-01-12 01:29:30 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -198,2 +196,3 @@
if not value.isnumeric():
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform('modules.base.user.set.error.value_type_not_numeric'))
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(
'modules.base.user.set.error.value_type_not_numeric'))
Ebola-Chan commented 2023-01-12 01:29:35 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -205,2 +204,3 @@
self._logger.error(__name__, f'String value couldn\'t be converted to int', te)
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform('modules.base.user.set.error.type_error'))
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(
'modules.base.user.set.error.type_error'))
Ebola-Chan commented 2023-01-12 01:29:39 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -213,2 +213,3 @@
else:
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform('modules.base.user.error.atr_not_found').format(atr))
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(
'modules.base.user.error.atr_not_found').format(atr))
Ebola-Chan commented 2023-01-12 01:29:44 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -216,2 +217,3 @@
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(f'modules.base.user.set.{atr.lower()}').format(member.mention, value))
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(
f'modules.base.user.set.{atr.lower()}').format(member.mention, value))
Ebola-Chan commented 2023-01-12 01:29:50 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -247,2 +249,3 @@
else:
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform('modules.base.user.error.atr_not_found').format(atr))
await self._message_service.send_interaction_msg(ctx.interaction, self._t.transform(
'modules.base.user.error.atr_not_found').format(atr))
Ebola-Chan commented 2023-01-12 01:29:57 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/user_group.py Outdated
@@ -256,2 +259,3 @@
@remove.autocomplete('atr')
async def remove_autocomplete(self, interaction: discord.Interaction, current: str) -> List[app_commands.Choice[str]]:
async def remove_autocomplete(self, interaction: discord.Interaction, current: str) -> List[
app_commands.Choice[str]]:
Ebola-Chan commented 2023-01-12 01:30:14 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
kdb-bot/src/modules/base/events/base_on_voice_state_update_event.py Outdated
@@ -87,2 +90,3 @@
@EventChecks.check_is_ready()
async def on_voice_state_update(self, member: discord.Member, before: discord.VoiceState, after: discord.VoiceState):
async def on_voice_state_update(self, member: discord.Member, before: discord.VoiceState,
after: discord.VoiceState):
Ebola-Chan commented 2023-01-12 01:31:06 +01:00
Contributor
Copy Link

Formatierung

Formatierung
edraft marked this conversation as resolved
edraft force-pushed #166 from 27ef1a709c to b80958e3ab 2023-01-12 07:14:56 +01:00 Compare
edraft added 1 commit 2023-01-12 07:20:03 +01:00
Improved formatting #166 3cf0fe3479
edraft requested review from Ebola-Chan 2023-01-12 07:20:11 +01:00
edraft added 1 commit 2023-01-13 12:23:54 +01:00
Centralised ontime calculation #166 34ebb48c83
Ebola-Chan approved these changes 2023-01-13 22:11:27 +01:00
edraft merged commit f9593b5f44 into 0.3.1 2023-01-13 22:14:58 +01:00
edraft deleted branch #166 2023-01-13 22:14:58 +01:00
edraft removed this from the Patch 0.3.1 milestone 2023-02-13 10:31:35 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Ebola-Chan
Labels
Clear labels
MVP
web-interface
bug
Something is not working
bugfix
Solution of a problem
cli
Changes for command line interface
discussion
Something needs to be discussed
documentation
Indicates a need for improvements or additions to documentation
duplicate
This issue or pull request already exists
expense
high
expense
low
expense
medium
expense
very-high
help wanted
Need some help
improvement
Improvement of a feature
invalid
Something is wrong
priority
blocker
priority
high
priority
low
priority
medium
question
More information is needed
refactoring
Code need some refactoring
release
Create a release
story
New feature
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Patch 0.3.1
Assignees
Clear assignees
ci edraft edraft-dev
No Assignees edraft
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#172
No description provided.
Delete Branch "#166"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?