sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

Added presence command #18 #126

Merged
edraft merged 2 commits from #18 into 0.3 2022-11-20 15:41:26 +01:00
Conversation 0 Commits 2 Files Changed 4 +9 -7
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7fb6d22c3f - Show all commits

16
kdb-bot/src/modules/base/command/presence_command.py
View File

@ -29,18 +29,20 @@ class PresenceCommand(DiscordCommandABC):
@commands.hybrid_command()
@commands.guild_only()
@CommandChecks.check_is_ready()
@CommandChecks.check_is_member_technician()
@CommandChecks.check_is_member_moderator()
Ebola-Chan marked this conversation as resolved Outdated
edraft commented 2022-11-20 14:25:04 +01:00
Outdated
Review
Copy Link

Moderator nicht Techniker

Moderator nicht Techniker
Ebola-Chan commented 2022-11-20 14:51:20 +01:00
Outdated
Review
Copy Link

Hatten wir das nicht besprochen dass nur wir die Presence setzen sollen, da diese Global ist?

Hatten wir das nicht besprochen dass nur wir die Presence setzen sollen, da diese Global ist?
edraft commented 2022-11-20 14:56:47 +01:00
Outdated
Review
Copy Link

War ein aspekt aber mir solls egal sein, zu mal das nicht im Issue geändert wurde.

War ein aspekt aber mir solls egal sein, zu mal das nicht im Issue geändert wurde.
async def presence(self, ctx: Context, text: str = ''):
self._logger.debug(__name__, f'Received command presence {ctx}')
if text == '':
Ebola-Chan marked this conversation as resolved
edraft commented 2022-11-20 14:29:02 +01:00
Review
Copy Link

early returns pls:

if text == '':
    await self._bot.change_presence(activity=None)
    await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.removed'))
    return

if len(text) > 128:
	await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.max_char_count_exceeded'))
	return

await self._bot.change_presence(activity=discord.Game(name=text))
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.changed'))
early returns pls: ```py if text == '': await self._bot.change_presence(activity=None) await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.removed')) return if len(text) > 128: await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.max_char_count_exceeded')) return await self._bot.change_presence(activity=discord.Game(name=text)) await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.changed')) ```
await self._bot.change_presence(activity=None)
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.removed'))
else:
if len(text) > 128:
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.max_char_count_exceeded'))
else:
await self._bot.change_presence(activity=discord.Game(name=text))
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.changed'))
return
if len(text) > 128:
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.max_char_count_exceeded'))
return
await self._bot.change_presence(activity=discord.Game(name=text))
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.changed'))
self._logger.trace(__name__, f'Finished presence command')