sh-edraft.de/sh_discord_bot
5
1
Fork 1
Code Issues 26 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

Added presence command #18 #126

Merged
edraft merged 2 commits from #18 into 0.3 2022-11-20 15:41:26 +01:00
Conversation 2 Commits 2 Files Changed 4 +56 -1
Ebola-Chan commented 2022-11-20 14:17:55 +01:00
Contributor
Copy Link

#18

#18
Ebola-Chan added this to the Sprint 0.3 milestone 2022-11-20 14:17:55 +01:00
Ebola-Chan self-assigned this 2022-11-20 14:17:55 +01:00
Ebola-Chan added 1 commit 2022-11-20 14:17:56 +01:00
Added presence command #18 c5b5297058
Ebola-Chan requested review from edraft 2022-11-20 14:18:01 +01:00
Ebola-Chan added this to the Sprint 0.3 project 2022-11-20 14:18:10 +01:00
edraft requested changes 2022-11-20 14:30:32 +01:00
kdb-bot/src/modules/base/command/presence_command.py Outdated
@@ -0,0 +29,4 @@
@commands.hybrid_command()
@commands.guild_only()
@CommandChecks.check_is_ready()
@CommandChecks.check_is_member_technician()
edraft commented 2022-11-20 14:25:04 +01:00
Owner
Copy Link

Moderator nicht Techniker

Moderator nicht Techniker
Ebola-Chan commented 2022-11-20 14:51:20 +01:00
Author
Contributor
Copy Link

Hatten wir das nicht besprochen dass nur wir die Presence setzen sollen, da diese Global ist?

Hatten wir das nicht besprochen dass nur wir die Presence setzen sollen, da diese Global ist?
edraft commented 2022-11-20 14:56:47 +01:00
Owner
Copy Link

War ein aspekt aber mir solls egal sein, zu mal das nicht im Issue geändert wurde.

War ein aspekt aber mir solls egal sein, zu mal das nicht im Issue geändert wurde.
Ebola-Chan marked this conversation as resolved
kdb-bot/src/modules/base/command/presence_command.py
@@ -0,0 +33,4 @@
async def presence(self, ctx: Context, text: str = ''):
self._logger.debug(__name__, f'Received command presence {ctx}')
if text == '':
edraft commented 2022-11-20 14:29:02 +01:00
Owner
Copy Link

early returns pls:

if text == '':
    await self._bot.change_presence(activity=None)
    await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.removed'))
    return

if len(text) > 128:
	await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.max_char_count_exceeded'))
	return

await self._bot.change_presence(activity=discord.Game(name=text))
await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.changed'))
early returns pls: ```py if text == '': await self._bot.change_presence(activity=None) await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.removed')) return if len(text) > 128: await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.max_char_count_exceeded')) return await self._bot.change_presence(activity=discord.Game(name=text)) await self._message_service.send_ctx_msg(ctx, self._t.transform('modules.base.presence.changed')) ```
Ebola-Chan marked this conversation as resolved
Ebola-Chan added 1 commit 2022-11-20 15:39:43 +01:00
Added requested changes to presence command #18 7fb6d22c3f
edraft approved these changes 2022-11-20 15:41:08 +01:00
edraft merged commit c7a925b997 into 0.3 2022-11-20 15:41:26 +01:00
edraft deleted branch #18 2022-11-20 15:41:27 +01:00
edraft removed this from the Sprint 0.3 milestone 2023-02-13 10:29:20 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
edraft
Labels
Clear labels
MVP
web-interface
bug
Something is not working
bugfix
Solution of a problem
cli
Changes for command line interface
discussion
Something needs to be discussed
documentation
Indicates a need for improvements or additions to documentation
duplicate
This issue or pull request already exists
expense
high
expense
low
expense
medium
expense
very-high
help wanted
Need some help
improvement
Improvement of a feature
invalid
Something is wrong
priority
blocker
priority
high
priority
low
priority
medium
question
More information is needed
refactoring
Code need some refactoring
release
Create a release
story
New feature
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Sprint 0.3
Assignees
Clear assignees
ci edraft edraft-dev MonkeyDGoku1996 pvtkeks tammo
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#126
No description provided.
Delete Branch "#18"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?