sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

0.3 - Statistiken (#46) #102

Merged
edraft merged 28 commits from #46 into 0.3 2022-11-09 20:55:06 +01:00
Conversation 0 Commits 28 Files Changed 29 +839 -13
edraft commented 2022-11-09 19:23:41 +01:00
Owner
Copy Link

#46

#46
edraft self-assigned this 2022-11-09 19:23:41 +01:00
edraft added 12 commits 2022-11-09 19:23:41 +01:00
edraft added this to the Sprint 0.3 milestone 2022-11-09 19:23:44 +01:00
edraft added this to the Sprint 0.3 project 2022-11-09 19:23:46 +01:00
edraft requested review from Ebola-Chan 2022-11-09 19:23:48 +01:00
edraft added 13 commits 2022-11-09 19:54:48 +01:00 
 Conflicts:
	kdb-bot/src/modules/level/level_seeder.py
edraft added 1 commit 2022-11-09 19:57:18 +01:00
edraft changed title from WIP: 0.3 - Statistiken (#46) to 0.3 - Statistiken (#46) 2022-11-09 19:57:43 +01:00
Ebola-Chan requested changes 2022-11-09 20:06:40 +01:00
kdb-bot/src/modules/level/level_seeder.py Outdated
@ -35,7 +35,6 @@ class LevelSeeder(DataSeederABC):
levels = self._levels.find_levels_by_server_id(server.server_id)
if levels is None or levels.where(lambda l: l.name == level.name).first_or_default() is None:
self._levels.add_level(level)
self._logger.debug(__name__, f'Saved level {level.name}')
Ebola-Chan commented 2022-11-09 20:05:35 +01:00
Contributor
Copy Link

Ein DebugLog wurde entfernt. War dies gewollt?

Ein DebugLog wurde entfernt. War dies gewollt?
edraft marked this conversation as resolved
edraft added 1 commit 2022-11-09 20:07:40 +01:00
Ebola-Chan requested changes 2022-11-09 20:48:17 +01:00
kdb-bot/src/modules/stats/command/stats_group.py Outdated
@ -0,0 +84,4 @@
descriptions += f'\n{statistic.description}'
embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True)
embed.add_field(name=self._t.transform('modules.stats.list.description'), value=statistics, inline=True)
Ebola-Chan commented 2022-11-09 20:24:43 +01:00
Contributor
Copy Link

Hier wurde zwei mal value=statisticsangegeben

embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True)
embed.add_field(name=self._t.transform('modules.stats.list.description'), value=statistics, inline=True)

statt

embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True)
embed.add_field(name=self._t.transform('modules.stats.list.description'), value=descriptions, inline=True)
Hier wurde zwei mal ```value=statistics```angegeben ```python embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True) embed.add_field(name=self._t.transform('modules.stats.list.description'), value=statistics, inline=True) ``` statt ```python embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True) embed.add_field(name=self._t.transform('modules.stats.list.description'), value=descriptions, inline=True) ```
edraft marked this conversation as resolved
kdb-bot/src/modules/stats/command/stats_group.py
@ -0,0 +94,4 @@
self._logger.debug(__name__, f'Received command stats {ctx}:{name}')
if not await self._client_utils.check_if_bot_is_ready_yet_and_respond(ctx):
return
Ebola-Chan commented 2022-11-09 20:26:08 +01:00
Contributor
Copy Link

Fehlt hier nicht noch ein Permission check?

if not self._permissions.is_member_moderator(ctx.author):
    await self._message_service.send_ctx_msg(ctx, self._t.transform('common.no_permission_message'))
    self._logger.trace(__name__, f'Finished command stats list')
    return
Fehlt hier nicht noch ein Permission check? ```python if not self._permissions.is_member_moderator(ctx.author): await self._message_service.send_ctx_msg(ctx, self._t.transform('common.no_permission_message')) self._logger.trace(__name__, f'Finished command stats list') return ```
edraft marked this conversation as resolved
kdb-bot/src/modules/stats/service/statistic_service.py
@ -0,0 +58,4 @@
self._clients
.get_clients()
.where(lambda x: x.server.server_id == server.server_id),
self._known_users.get_users(),
Ebola-Chan commented 2022-11-09 20:41:57 +01:00
Contributor
Copy Link

Ich merke hier mal an dass self._known_users.get_users() kein Lamdaausdruck hat wie die anderen Parametern. Sollte dies hier nicht gebraucht werden, dann dieser Thread resolved werden.

Ich merke hier mal an dass ```self._known_users.get_users()``` kein Lamdaausdruck hat wie die anderen Parametern. Sollte dies hier nicht gebraucht werden, dann dieser Thread resolved werden.
edraft commented 2022-11-09 20:52:39 +01:00
Author
Owner
Copy Link

KnownUsers ist ne Liste aller bekannten discord.Member

KnownUsers ist ne Liste aller bekannten discord.Member
edraft marked this conversation as resolved
edraft added 1 commit 2022-11-09 20:53:00 +01:00
edraft requested review from Ebola-Chan 2022-11-09 20:53:35 +01:00
Ebola-Chan approved these changes 2022-11-09 20:54:53 +01:00
edraft merged commit 2483faef01 into 0.3 2022-11-09 20:55:06 +01:00
edraft deleted branch #46 2022-11-09 20:55:06 +01:00
edraft removed this from the Sprint 0.3 milestone 2023-02-13 10:28:35 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Ebola-Chan
Labels
Clear labels   
MVP

   
web-interface
  
bug

Something is not working

  
bugfix

Solution of a problem

  
cli

Changes for command line interface

  
discussion

Something needs to be discussed

  
documentation

Indicates a need for improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
expense
high

  
expense
low

  
expense
medium

  
expense
very-high

  
help wanted

Need some help

  
improvement

Improvement of a feature

  
invalid

Something is wrong

  
priority
blocker

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
refactoring

Code need some refactoring

  
release

Create a release

  
story

New feature

  
wontfix

This won't be fixed

No Label
MVP
web-interface
bug
bugfix
cli
discussion
documentation
duplicate
expense
high
expense
low
expense
medium
expense
very-high
help wanted
improvement
invalid
priority
blocker
priority
high
priority
low
priority
medium
question
refactoring
release
story
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Sprint 0.3
Assignees
Clear assignees
No Assignees
edraft
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#102
No description provided.
Delete Branch "#46"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?