sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

#238 #242

Merged
edraft merged 5 commits from #238 into 1.0.0 2023-03-06 08:42:22 +01:00
Conversation 0 Commits 5 Files Changed 28 +968 -187
edraft commented 2023-03-05 14:17:54 +01:00
Owner
Copy Link
No description provided.
edraft self-assigned this 2023-03-05 14:17:54 +01:00
edraft added 2 commits 2023-03-05 14:17:54 +01:00
edraft added this to the Sprint 1.0.0 project 2023-03-05 14:17:57 +01:00
edraft requested review from Ebola-Chan 2023-03-05 14:17:59 +01:00
edraft changed title from WIP: #238 to #238 2023-03-05 21:48:06 +01:00
edraft added this to the Sprint 1.0.0 milestone 2023-03-05 21:56:05 +01:00
edraft removed this from the Sprint 1.0.0 milestone 2023-03-05 21:56:09 +01:00
Ebola-Chan requested changes 2023-03-06 01:16:17 +01:00
kdb-bot/src/bot/translation/de.json Outdated
@ -149,1 +149,4 @@
"afk_command_move_message": "Ich verschiebe dich ja schon... (◔_◔)",
"game_server": {
"error": {
"nothing_found": "Keine Level Einträge gefunden."
Ebola-Chan commented 2023-03-05 22:00:13 +01:00
Contributor
Copy Link
"nothing_found": "Keine Leveleinträge gefunden."
```json "nothing_found": "Keine Leveleinträge gefunden." ```
edraft marked this conversation as resolved
kdb-bot/src/bot_data/model/game_server.py Outdated
@ -0,0 +118,4 @@
return str(
f"""
UPDATE `GameServers`
SET `LastModifiedAt` = '{self._modified_at}'
Ebola-Chan commented 2023-03-05 22:33:35 +01:00
Contributor
Copy Link

Ist das so richtig, dass nur "LastModifiedAt" geupdatet wird und keine weitere Variable?

Ist das so richtig, dass nur "LastModifiedAt" geupdatet wird und keine weitere Variable?
edraft commented 2023-03-06 08:01:03 +01:00
Author
Owner
Copy Link

Alles andere soll read only sein.
Jedoch möchte ich das schnell ändern können.

Alles andere soll read only sein. Jedoch möchte ich das schnell ändern können.
edraft marked this conversation as resolved
kdb-bot/src/bot_data/model/user_game_ident.py Outdated
@ -0,0 +116,4 @@
def delete_string(self) -> str:
return str(
f"""
DELETE FROM `UserGameIdents`
Ebola-Chan commented 2023-03-05 22:43:34 +01:00
Contributor
Copy Link

Hier auch nur "LastModifiedAt" updaten?

Hier auch nur "LastModifiedAt" updaten?
edraft commented 2023-03-06 08:01:09 +01:00
Author
Owner
Copy Link

Alles andere soll read only sein.
Jedoch möchte ich das schnell ändern können.

Alles andere soll read only sein. Jedoch möchte ich das schnell ändern können.
edraft marked this conversation as resolved
kdb-bot/src/modules/base/command/game_server_group.py Outdated
@ -0,0 +99,4 @@
@commands.guild_only()
@CommandChecks.check_is_ready()
@CommandChecks.check_is_member_admin()
async def add(self, ctx: Context, name: str, api_key_id: int):
Ebola-Chan commented 2023-03-06 00:22:29 +01:00
Contributor
Copy Link

Was passiert wenn man den selben API-Key nochmal hinzufügt?

Was passiert wenn man den selben API-Key nochmal hinzufügt?
edraft commented 2023-03-06 08:03:28 +01:00
Author
Owner
Copy Link

Technishc nicht möglich "CONSTRAINT UC_Identifier_Key UNIQUE (Identifier,Key),"
Dann wird ein entsprechender Fehler geschmissen, der so auch nicht zwangsläufig abgefangen werden müsste. (Command Error handling regelt)

Technishc nicht möglich "CONSTRAINT UC_Identifier_Key UNIQUE (`Identifier`,`Key`)," Dann wird ein entsprechender Fehler geschmissen, der so auch nicht zwangsläufig abgefangen werden müsste. (Command Error handling regelt)
edraft marked this conversation as resolved
edraft force-pushed #238 from efb6289e67 to 1b328dc20e 2023-03-06 08:05:36 +01:00 Compare
edraft requested review from Ebola-Chan 2023-03-06 08:05:44 +01:00
Ebola-Chan approved these changes 2023-03-06 08:41:16 +01:00
edraft merged commit f02268c1a1 into 1.0.0 2023-03-06 08:42:22 +01:00
edraft deleted branch #238 2023-03-06 08:42:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Ebola-Chan
Labels
Clear labels   
MVP

   
web-interface
  
bug

Something is not working

  
bugfix

Solution of a problem

  
cli

Changes for command line interface

  
discussion

Something needs to be discussed

  
documentation

Indicates a need for improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
expense
high

  
expense
low

  
expense
medium

  
expense
very-high

  
help wanted

Need some help

  
improvement

Improvement of a feature

  
invalid

Something is wrong

  
priority
blocker

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
refactoring

Code need some refactoring

  
release

Create a release

  
story

New feature

  
wontfix

This won't be fixed

No Label
MVP
web-interface
bug
bugfix
cli
discussion
documentation
duplicate
expense
high
expense
low
expense
medium
expense
very-high
help wanted
improvement
invalid
priority
blocker
priority
high
priority
low
priority
medium
question
refactoring
release
story
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Sprint 1.0.0
Assignees
Clear assignees
No Assignees
edraft
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#242
No description provided.
Delete Branch "#238"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?