0.3 - Statistiken (#46) #102

Merged
edraft merged 28 commits from #46 into 0.3 2022-11-09 20:55:06 +01:00
Owner

#46

#46
edraft self-assigned this 2022-11-09 19:23:41 +01:00
edraft added 12 commits 2022-11-09 19:23:41 +01:00
edraft added this to the Sprint 0.3 milestone 2022-11-09 19:23:44 +01:00
edraft added this to the Sprint 0.3 project 2022-11-09 19:23:46 +01:00
edraft requested review from Ebola-Chan 2022-11-09 19:23:48 +01:00
edraft added 13 commits 2022-11-09 19:54:48 +01:00
edraft added 1 commit 2022-11-09 19:57:18 +01:00
edraft changed title from WIP: 0.3 - Statistiken (#46) to 0.3 - Statistiken (#46) 2022-11-09 19:57:43 +01:00
Ebola-Chan requested changes 2022-11-09 20:06:40 +01:00
@ -35,7 +35,6 @@ class LevelSeeder(DataSeederABC):
levels = self._levels.find_levels_by_server_id(server.server_id)
if levels is None or levels.where(lambda l: l.name == level.name).first_or_default() is None:
self._levels.add_level(level)
self._logger.debug(__name__, f'Saved level {level.name}')
Contributor

Ein DebugLog wurde entfernt. War dies gewollt?

Ein DebugLog wurde entfernt. War dies gewollt?
edraft marked this conversation as resolved
edraft added 1 commit 2022-11-09 20:07:40 +01:00
Ebola-Chan requested changes 2022-11-09 20:48:17 +01:00
@ -0,0 +84,4 @@
descriptions += f'\n{statistic.description}'
embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True)
embed.add_field(name=self._t.transform('modules.stats.list.description'), value=statistics, inline=True)
Contributor

Hier wurde zwei mal value=statisticsangegeben

embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True)
embed.add_field(name=self._t.transform('modules.stats.list.description'), value=statistics, inline=True)

statt

embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True)
embed.add_field(name=self._t.transform('modules.stats.list.description'), value=descriptions, inline=True)
Hier wurde zwei mal ```value=statistics```angegeben ```python embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True) embed.add_field(name=self._t.transform('modules.stats.list.description'), value=statistics, inline=True) ``` statt ```python embed.add_field(name=self._t.transform('modules.stats.list.statistic'), value=statistics, inline=True) embed.add_field(name=self._t.transform('modules.stats.list.description'), value=descriptions, inline=True) ```
edraft marked this conversation as resolved
@ -0,0 +94,4 @@
self._logger.debug(__name__, f'Received command stats {ctx}:{name}')
if not await self._client_utils.check_if_bot_is_ready_yet_and_respond(ctx):
return
Contributor

Fehlt hier nicht noch ein Permission check?

if not self._permissions.is_member_moderator(ctx.author):
    await self._message_service.send_ctx_msg(ctx, self._t.transform('common.no_permission_message'))
    self._logger.trace(__name__, f'Finished command stats list')
    return
Fehlt hier nicht noch ein Permission check? ```python if not self._permissions.is_member_moderator(ctx.author): await self._message_service.send_ctx_msg(ctx, self._t.transform('common.no_permission_message')) self._logger.trace(__name__, f'Finished command stats list') return ```
edraft marked this conversation as resolved
@ -0,0 +58,4 @@
self._clients
.get_clients()
.where(lambda x: x.server.server_id == server.server_id),
self._known_users.get_users(),
Contributor

Ich merke hier mal an dass self._known_users.get_users() kein Lamdaausdruck hat wie die anderen Parametern. Sollte dies hier nicht gebraucht werden, dann dieser Thread resolved werden.

Ich merke hier mal an dass ```self._known_users.get_users()``` kein Lamdaausdruck hat wie die anderen Parametern. Sollte dies hier nicht gebraucht werden, dann dieser Thread resolved werden.
Author
Owner

KnownUsers ist ne Liste aller bekannten discord.Member

KnownUsers ist ne Liste aller bekannten discord.Member
edraft marked this conversation as resolved
edraft added 1 commit 2022-11-09 20:53:00 +01:00
edraft requested review from Ebola-Chan 2022-11-09 20:53:35 +01:00
Ebola-Chan approved these changes 2022-11-09 20:54:53 +01:00
edraft merged commit 2483faef01 into 0.3 2022-11-09 20:55:06 +01:00
edraft deleted branch #46 2022-11-09 20:55:06 +01:00
edraft removed this from the Sprint 0.3 milestone 2023-02-13 10:28:35 +01:00
Sign in to join this conversation.
No description provided.