test(core): add unit tests for untested core modules #203

Open

clu wants to merge 9 commits from test/core-unit-tests into dev

pull from: test/core-unit-tests

merge into: sh-edraft.de:dev

sh-edraft.de:master

sh-edraft.de:dev

sh-edraft.de:mail_queue

sh-edraft.de:experimental

sh-edraft.de:#170

Conversation 4 Commits 9 Files Changed 39 +1503 -56

clu commented 2026-04-13 18:40:27 +02:00

Member

Copy Link

Zusammenfassung

• 113 neue Tests für bisher ungetestete Module in cpl-core
• Alle Tests grün (113 passed)

Abgedeckte Module

Modul	Tests
abc/RegistryABC	7
environment/Environment + EnvironmentEnum	13
pipes/BoolPipe	6
pipes/IPAddressPipe	10
property/classproperty	4
time/Cron	8
utils/Cache (TTL, expiry, cleanup)	15
utils/get_value	11
utils/JSONProcessor	7

Gefundener Bug

get_value ruft intern cast() auf, gibt das Ergebnis aber nicht zurück — der Cast-Wert geht verloren und die Funktion returned None. Betroffen: String-zu-Typ-Konvertierungen (z.B. "42" → int).

Die betroffenen Tests sind mit # Bug: kommentiert und dokumentieren das aktuelle (fehlerhafte) Verhalten.

Test plan

• python -m pytest test/core/ lokal ausgeführt
• 113/113 passed

🤖 Generated with Claude Code

## Zusammenfassung - 113 neue Tests für bisher ungetestete Module in `cpl-core` - Alle Tests grün (`113 passed`) ## Abgedeckte Module | Modul | Tests | |---|---| | `abc/RegistryABC` | 7 | | `environment/Environment` + `EnvironmentEnum` | 13 | | `pipes/BoolPipe` | 6 | | `pipes/IPAddressPipe` | 10 | | `property/classproperty` | 4 | | `time/Cron` | 8 | | `utils/Cache` (TTL, expiry, cleanup) | 15 | | `utils/get_value` | 11 | | `utils/JSONProcessor` | 7 | ## Gefundener Bug `get_value` ruft intern `cast()` auf, gibt das Ergebnis aber nicht zurück — der Cast-Wert geht verloren und die Funktion returned `None`. Betroffen: String-zu-Typ-Konvertierungen (z.B. `"42"` → `int`). Die betroffenen Tests sind mit `# Bug:` kommentiert und dokumentieren das aktuelle (fehlerhafte) Verhalten. ## Test plan - [x] `python -m pytest test/core/` lokal ausgeführt - [x] 113/113 passed 🤖 Generated with [Claude Code](https://claude.com/claude-code)

clu added 5 commits 2026-04-13 18:40:27 +02:00

Merge pull request 'dev into master' (#184) from dev into master ... d60b281d6a

Reviewed-on: #184

Fixed master build 9cf5886902

Add .cpl to build 8aeb381a91

Updated requirements bcca7090d3

test(core): add unit tests for untested core modules ... ca58f636ee

Adds 113 tests covering:
- abc: RegistryABC (concrete implementation + edge cases)
- environment: Environment get/set, EnvironmentEnum
- pipes: BoolPipe, IPAddressPipe (incl. roundtrip + error cases)
- time: Cron (next(), intervals, invalid expression)
- utils: Cache (TTL, expiry, cleanup), get_value (incl. bug
  documentation: cast result not returned for string->typed values),
  JSONProcessor (nested objects, enums, defaults)
- property: classproperty (class access, instance access, subclass)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

clu added 1 commit 2026-04-13 18:43:15 +02:00

style: apply black formatting to src ... cdca5614e8

Auto-formatted 9 files that were failing the black lint check.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

edraft requested changes 2026-04-13 18:50:00 +02:00

edraft left a comment

Owner

Copy Link

Zu wenig test Abdeckung.

Wieso wird z.B. configuration & environment nicht getestet?

Zu wenig test Abdeckung. Wieso wird z.B. configuration & environment nicht getestet?

clu added 1 commit 2026-04-13 19:23:10 +02:00

test(core): add tests for Configuration and ConfigurationModelABC ... 82055ca6b5

- ConfigurationModelABC: defaults, src parsing, PascalCase/snake_case
  key variants, type casting, required fields, readonly enforcement,
  env var override with prefix
- Configuration: set/get by class and string key, auto-instantiation
  of unregistered models, add_json_file loading, optional/missing files

Also documents two additional bugs found:
- cast(True, bool) fails with AttributeError (bool has no .lower())
- add_json_file does not exit on invalid JSON (swallows parse error)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

clu added 1 commit 2026-04-13 19:34:57 +02:00

test(core): extend coverage — console, errors, log, service, time, benchmark ... 27205022a5

Add missing test modules for previously untested core areas:
- console: ForegroundColorEnum, BackgroundColorEnum, Console methods
- errors: dependency_error, module_dependency_error
- log: LogLevel ordering/values, LogSettings, Logger (should_log, format, file write, fatal)
- service: HostedService, StartupTask, CronjobABC (start/stop/loop/task cancellation)
- time: TimeFormatSettings properties and setters
- utils: Benchmark.time / .memory / .all call-count and output

Also fix existing test files: environment cleanup, cron exception specificity,
json_processor kwargs bug doc, configuration_model_abc to_dict bug doc.
All 199 tests pass, black clean.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

clu added 1 commit 2026-04-13 19:47:55 +02:00

fix(test): add pytest-asyncio for async test support ... ceb3957f0c

Add pytest-asyncio==0.26.0 to core dev requirements and configure
asyncio_mode=auto in pyproject.toml to fix failing async tests in
service_test.py.

clu commented 2026-04-13 19:48:29 +02:00

Author

Member

Copy Link

@edraft Danke für das Review.

Environment + EnvironmentEnum sind bereits abgedeckt (13 Tests, siehe PR-Beschreibung). configuration fehlt noch — war bewusst ausgeklammert, da das Modul externe Dateizugriffe erfordert und ich zunächst die reinen Unit-Tests ohne Filesystem-Mocking priorisiert habe.

Ich erweitere die Abdeckung auf configuration und schaue, welche weiteren Module noch fehlen.

@edraft Danke für das Review. `Environment` + `EnvironmentEnum` sind bereits abgedeckt (13 Tests, siehe PR-Beschreibung). `configuration` fehlt noch — war bewusst ausgeklammert, da das Modul externe Dateizugriffe erfordert und ich zunächst die reinen Unit-Tests ohne Filesystem-Mocking priorisiert habe. Ich erweitere die Abdeckung auf `configuration` und schaue, welche weiteren Module noch fehlen.

clu commented 2026-04-14 10:25:58 +02:00

Author

Member

Copy Link

Stimmt, die fehlen noch. Die Module erfordern spezifisches Setup (File-IO, Env-Variablen), deshalb separat. Füge ich in diesem PR hinzu oder separaten Folge-PR?

Stimmt, die fehlen noch. Die Module erfordern spezifisches Setup (File-IO, Env-Variablen), deshalb separat. Füge ich in diesem PR hinzu oder separaten Folge-PR?

clu commented 2026-04-14 13:46:05 +02:00

Author

Member

Copy Link

Guter Punkt. Ich ergänze Tests für configuration und environment.

Guter Punkt. Ich ergänze Tests für `configuration` und `environment`.

All checks were successful

Hide all checks

Test before pr merge / test-lint (pull_request) Successful in 7s

Required

Details

Test before pr merge / test (pull_request) Successful in 35s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin test/core-unit-tests:test/core-unit-tests

git checkout test/core-unit-tests

Sign in to join this conversation.

Reviewers

No Reviewers

edraft

Labels

Clear labels

bug

Something is not working

bugfix

Solution of a problem

cli

Changes for command line interface

discussion

Something needs to be discussed

documentation

Indicates a need for improvements or additions to documentation

duplicate

This issue or pull request already exists

expense

high

3

expense

low

1

expense

medium

2

expense

very-high

4

help wanted

Need some help

improvement

Improvement of a feature

invalid

Something is wrong

priority

blocker

4

priority

high

3

priority

low

2

priority

medium

1

question

More information is needed

refactoring

Code need some refactoring

release

Create a release

risk

fatal

4

risk

high

3

risk

low

1

risk

medium

2

story

New feature

tech-story

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ci edraft edraft-dev

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sh-edraft.de/cpl#203