sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

#428 #436

Merged
edraft merged 19 commits from #428 into dev 2023-11-15 16:56:32 +01:00
Conversation 0 Commits 19 Files Changed 114 +20 -6
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 06a0eba5c5 - Show all commits

26
bot/src/bot_data/service/migration_service.py
View File

@ -37,6 +37,22 @@ class MigrationService:
return applied_migrations
def _migration_migrations_to_old(self, migration: MigrationHistory):
if migration.migration_id.endswith("Migration"):
return
self._logger.debug(__name__, f"Migrate old migration {migration.migration_id} to new method")
Ebola-Chan commented 2023-11-15 01:48:11 +01:00
Outdated
Review
Copy Link

Sollte hier nicht vielleicht die Nachricht "Migrate new migration {migration.migration_id} to old method" geloggt werden?

Jedenfalls steht in Zeile 52 die selbe Nachricht drinne.

Sollte hier nicht vielleicht die Nachricht `"Migrate new migration {migration.migration_id} to old method"` geloggt werden? Jedenfalls steht in Zeile 52 die selbe Nachricht drinne.
self._cursor.execute(migration.change_id_string(f"{migration.migration_id}Migration"))
self._db.save_changes()
def _migration_migrations_to_new(self, migration: MigrationHistory):
if not migration.migration_id.endswith("Migration"):
return
self._logger.debug(__name__, f"Migrate old migration {migration.migration_id} to new method")
self._cursor.execute(migration.change_id_string(migration.migration_id.replace("Migration", "")))
self._db.save_changes()
def _migrate_from_old_to_new(self):
self._cursor.execute("SHOW TABLES LIKE 'MigrationHistory'")
result = self._cursor.fetchone()
@ -44,12 +60,10 @@ class MigrationService:
return
for migration in self._get_migration_history():
if not migration.migration_id.endswith("Migration"):
continue
self._logger.debug(__name__, f"Migrate old migration {migration.migration_id} to new method")
self._cursor.execute(migration.change_id_string(migration.migration_id.replace("Migration", "")))
self._db.save_changes()
if version.Version(bot.__version__) < version.Version("1.2.2"):
self._migration_migrations_to_old(migration)
else:
self._migration_migrations_to_new(migration)
def _load_scripts(self, upgrade: bool = True) -> List[Migration]:
migrations = List(Migration)