#292_shutdown_procedure #321

Merged
edraft merged 6 commits from #292_shutdown_procedure into 1.1.0 2023-07-18 11:03:16 +02:00
2 changed files with 3 additions and 1 deletions
Showing only changes of commit 806144d9d3 - Show all commits

View File

@ -10,6 +10,7 @@ from cpl_translation import TranslatePipe, TranslationServiceABC, TranslationSet
from bot_api.api_thread import ApiThread
from bot_core.configuration.feature_flags_enum import FeatureFlagsEnum
from bot_core.configuration.feature_flags_settings import FeatureFlagsSettings
from bot_core.service.data_integrity_service import DataIntegrityService
class Application(DiscordBotApplicationABC):
@ -21,6 +22,7 @@ class Application(DiscordBotApplicationABC):
# cpl-core
self._logger: LoggerABC = services.get_service(LoggerABC)
self._data_integrity: DataIntegrityService = services.get_service(DataIntegrityService)
# cpl-discord
self._bot: DiscordBotServiceABC = services.get_service(DiscordBotServiceABC)
self._bot_settings: DiscordBotSettings = config.get_configuration(DiscordBotSettings)
@ -68,6 +70,7 @@ class Application(DiscordBotApplicationABC):
if self._feature_flags.get_flag(FeatureFlagsEnum.api_module):
self._api.stop()
self._data_integrity.check_data_integrity(is_for_shutdown=True)
await self._bot.close()
self._logger.info(__name__, f"Stopped {DiscordBotService.__name__}")
except Exception as e:

View File

@ -307,7 +307,6 @@ class DataIntegrityService:
join = UserJoinedVoiceChannel(user, member.voice.channel.id, datetime.now())
self._user_joins_vc.add_user_joined_voice_channel(join)
self._db_context.save_changes()
Ebola-Chan marked this conversation as resolved
Review

Wie unten Angemerkt kommt es zu einer NullReferenceException wenn user None ist. Evtl nach Protokollieren ein continue?

Wie unten Angemerkt kommt es zu einer NullReferenceException wenn ```user``` None ist. Evtl nach Protokollieren ein ```continue```?
self._logger.warn(__name__, f"VS {member.voice}")
except Exception as e:
Ebola-Chan marked this conversation as resolved
Review

Hier sollte es zu einer NullReferenceException kommen, wenn user None ist.

Hier sollte es zu einer NullReferenceException kommen, wenn ```user``` None ist.
self._logger.error(__name__, f"Cannot get UserJoinedVoiceChannel", e)