sh-edraft.de/sh_discord_bot
2
1
Fork 1
Code Issues 26 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

Fixed db null handling #219 #229

Merged
edraft merged 4 commits from #219 into 1.0.0 2023-02-21 21:10:18 +01:00
Conversation 3 Commits 4 Files Changed 6 +77 -117
edraft commented 2023-02-21 12:43:04 +01:00
Owner
Copy Link
No description provided.
edraft added 1 commit 2023-02-21 12:43:05 +01:00
Fixed db null handling #219 8937243725
edraft self-assigned this 2023-02-21 12:43:08 +01:00
edraft requested review from Ebola-Chan 2023-02-21 12:43:11 +01:00
edraft added this to the Sprint 1.0.0 project 2023-02-21 12:43:13 +01:00
edraft added 1 commit 2023-02-21 12:43:16 +01:00
Merge branch '1.0.0' into #219 6585576266
Ebola-Chan requested changes 2023-02-21 20:16:47 +01:00
kdb-bot/src/bot_data/model/user_joined_game_server.py
@@ -132,4 +117,4 @@
def udpate_string(self) -> str:
return str(
f"""
UPDATE `UserJoinedGameServer`
Ebola-Chan commented 2023-02-21 20:12:45 +01:00
Contributor
Copy Link

Wie wäre es hier mit:

def udpate_string(self) -> str:
    return str(
    	f"""
        UPDATE `UserJoinedGameServer`
        SET
        {"" if self._leaved_on is None else f"`LeavedOn` = '{self._leaved_on}',"}
        `LastModifiedAt` = '{self._modified_at}'
        WHERE `Id` = {self._id};
    """
    )

Somit wäre das SQL-Statement besser wartbar, sollte neue Variablen dazu kommen, welche Nullwerte beinhalten könnten.

Wie wäre es hier mit: ```python def udpate_string(self) -> str: return str( f""" UPDATE `UserJoinedGameServer` SET {"" if self._leaved_on is None else f"`LeavedOn` = '{self._leaved_on}',"} `LastModifiedAt` = '{self._modified_at}' WHERE `Id` = {self._id}; """ ) ``` Somit wäre das SQL-Statement besser wartbar, sollte neue Variablen dazu kommen, welche Nullwerte beinhalten könnten.
Ebola-Chan marked this conversation as resolved
kdb-bot/src/bot_data/model/user_joined_server.py Outdated
@@ -132,3 +118,2 @@
UPDATE `UserJoinedServers`
SET `LeavedOn` = '{self._leaved_on}',
`LastModifiedAt` = '{self._modified_at}'
{"" if self._leaved_on is None else f"SET `LeavedOn` = '{self._leaved_on}',"}
Ebola-Chan commented 2023-02-21 20:16:29 +01:00
Contributor
Copy Link

Auch hier das SQL-Statement so implementieren für bessere Wartbarkeit.

Auch hier das SQL-Statement so implementieren für bessere Wartbarkeit.
kdb-bot/src/bot_data/model/user_joined_voice_channel.py Outdated
@@ -142,3 +127,2 @@
UPDATE `UserJoinedVoiceChannel`
SET `LeavedOn` = '{self._leaved_on}',
`LastModifiedAt` = '{self._modified_at}'
{"" if self._leaved_on is None else f"SET `LeavedOn` = '{self._leaved_on}',"}
Ebola-Chan commented 2023-02-21 20:16:37 +01:00
Contributor
Copy Link

Auch hier das SQL-Statement so implementieren für bessere Wartbarkeit.

Auch hier das SQL-Statement so implementieren für bessere Wartbarkeit.
edraft added 1 commit 2023-02-21 20:51:32 +01:00
Improved SQL statements #219 d42b76ba87
Ebola-Chan requested changes 2023-02-21 21:00:51 +01:00
kdb-bot/src/bot_data/model/user_joined_game_server.py Outdated
@@ -134,3 +119,3 @@
f"""
UPDATE `UserJoinedGameServer`
SET `LeavedOn` = '{self._leaved_on}',
{"SET " if self._leaved_on is None else f"`LeavedOn` = '{self._leaved_on}',"}
Ebola-Chan commented 2023-02-21 21:00:12 +01:00
Contributor
Copy Link

Wenn self._leaved_on nicht none ist, käme es hier nicht zum folgenden SQL-Statement:

UPDATE `UserJoinedGameServer`
`LeavedOn' = '20230221T20:58.000'
`LastModifiedAt` = '20230221T20:58.000'
WHERE `Id` = 1;

Welches durch das fehlende SET nicht ausgeführt werden kann?

Wenn ```self._leaved_on``` nicht none ist, käme es hier nicht zum folgenden SQL-Statement: ```sql UPDATE `UserJoinedGameServer` `LeavedOn' = '20230221T20:58.000' `LastModifiedAt` = '20230221T20:58.000' WHERE `Id` = 1; ``` Welches durch das fehlende ```SET``` nicht ausgeführt werden kann?
kdb-bot/src/bot_data/model/user_joined_server.py Outdated
@@ -131,3 +117,3 @@
f"""
UPDATE `UserJoinedServers`
SET `LeavedOn` = '{self._leaved_on}',
{"SET " if self._leaved_on is None else f"`LeavedOn` = '{self._leaved_on}',"}
Ebola-Chan commented 2023-02-21 21:00:45 +01:00
Contributor
Copy Link

Auch hier das SET-Problem

Auch hier das SET-Problem
kdb-bot/src/bot_data/model/user_joined_voice_channel.py Outdated
@@ -141,3 +126,3 @@
f"""
UPDATE `UserJoinedVoiceChannel`
SET `LeavedOn` = '{self._leaved_on}',
{"SET " if self._leaved_on is None else f"`LeavedOn` = '{self._leaved_on}',"}
Ebola-Chan commented 2023-02-21 21:00:49 +01:00
Contributor
Copy Link

Auch hier das SET-Problem

Auch hier das SET-Problem
edraft added 1 commit 2023-02-21 21:08:54 +01:00
Improved SQL statements #219 f7dc8d135a
Ebola-Chan approved these changes 2023-02-21 21:09:50 +01:00
edraft merged commit 2763f254af into 1.0.0 2023-02-21 21:10:18 +01:00
edraft deleted branch #219 2023-02-21 21:10:18 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Ebola-Chan
Labels
Clear labels
MVP
web-interface
bug
Something is not working
bugfix
Solution of a problem
cli
Changes for command line interface
discussion
Something needs to be discussed
documentation
Indicates a need for improvements or additions to documentation
duplicate
This issue or pull request already exists
expense
high
expense
low
expense
medium
expense
very-high
help wanted
Need some help
improvement
Improvement of a feature
invalid
Something is wrong
priority
blocker
priority
high
priority
low
priority
medium
question
More information is needed
refactoring
Code need some refactoring
release
Create a release
story
New feature
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Sprint 1.0.0
Assignees
Clear assignees
ci edraft edraft-dev
No Assignees edraft
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#229
No description provided.
Delete Branch "#219"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?