Added logic to check server view permissions #339 #1.1.0.rc3

This commit is contained in:
Sven Heidemann 2023-08-16 20:55:42 +02:00
parent f5b2bec356
commit e283a18def
5 changed files with 55 additions and 17 deletions

View File

@ -1,6 +1,6 @@
{ {
"name": "kdb-web", "name": "kdb-web",
"version": "1.1.0.rc2", "version": "1.1.0.rc3",
"scripts": { "scripts": {
"ng": "ng", "ng": "ng",
"update-version": "ts-node-esm update-version.ts", "update-version": "ts-node-esm update-version.ts",

View File

@ -25,3 +25,9 @@ export interface UserDTO {
isAdmin: boolean; isAdmin: boolean;
isModerator: boolean; isModerator: boolean;
} }
export enum MemberRoles {
Moderator = 0,
Admin = 1,
Technician = 2,
}

View File

@ -1,17 +1,20 @@
import { Injectable } from '@angular/core'; import { Injectable } from "@angular/core";
import { ActivatedRouteSnapshot, CanActivate, Router, RouterStateSnapshot } from '@angular/router'; import { ActivatedRouteSnapshot, CanActivate, Router, RouterStateSnapshot } from "@angular/router";
import { catchError } from 'rxjs/operators'; import { catchError } from "rxjs/operators";
import { AuthService } from 'src/app/services/auth/auth.service'; import { AuthService } from "src/app/services/auth/auth.service";
import { ThemeService } from 'src/app/services/theme/theme.service'; import { ThemeService } from "src/app/services/theme/theme.service";
import { SidebarService } from "../../../../services/sidebar/sidebar.service";
import { MemberRoles } from "../../../../models/auth/auth-user.dto";
@Injectable({ @Injectable({
providedIn: 'root' providedIn: "root"
}) })
export class AuthGuard implements CanActivate { export class AuthGuard implements CanActivate {
constructor( constructor(
private router: Router, private router: Router,
private authService: AuthService, private authService: AuthService,
private themeService: ThemeService private themeService: ThemeService,
private sidebarService: SidebarService
) { ) {
} }
@ -26,19 +29,41 @@ export class AuthGuard implements CanActivate {
return false; return false;
} }
const role = route.data['role']; const role = route.data["role"];
if (role) { const memberRole = route.data["memberRole"];
if (role !== undefined) {
this.authService.hasUserPermission(role).then(async hasPermission => { this.authService.hasUserPermission(role).then(async hasPermission => {
let authUser = await this.authService.getLoggedInUser(); let authUser = await this.authService.getLoggedInUser();
let isTechnician = authUser?.users?.map(u => u.isTechnician).filter(u => u) ?? []; let isTechnician = authUser?.users?.map(u => u.isTechnician).filter(u => u) ?? [];
if (!hasPermission && !isTechnician) { if (!hasPermission && !isTechnician) {
this.router.navigate(['/dashboard']); this.router.navigate(["/dashboard"]);
return false; return false;
} }
return true; return true;
}); });
} }
if (memberRole !== undefined) {
let userHasAccess = false;
let authUser = await this.authService.getLoggedInUser();
authUser?.users?.forEach(u => {
if (u.server === +(this.sidebarService.server$.value?.id ?? 0)) {
if (
memberRole === MemberRoles.Moderator && u.isModerator ||
memberRole === MemberRoles.Admin && u.isAdmin ||
memberRole === MemberRoles.Technician && u.isTechnician
) {
userHasAccess = true;
}
}
});
if (!userHasAccess) {
this.router.navigate(["/dashboard"]);
return false;
}
return true;
}
return true; return true;
} }
} }

View File

@ -3,15 +3,22 @@ import { RouterModule, Routes } from "@angular/router";
import { ServerDashboardComponent } from "./server-dashboard/server-dashboard.component"; import { ServerDashboardComponent } from "./server-dashboard/server-dashboard.component";
import { ProfileComponent } from "./profile/profile.component"; import { ProfileComponent } from "./profile/profile.component";
import { MembersComponent } from "./members/members.component"; import { MembersComponent } from "./members/members.component";
import { AuthGuard } from "../../shared/guards/auth/auth.guard";
import { MemberRoles } from "../../../models/auth/auth-user.dto";
const routes: Routes = [ const routes: Routes = [
{ path: "", component: ServerDashboardComponent }, { path: "", component: ServerDashboardComponent },
{ path: "members", component: MembersComponent }, { path: "members", component: MembersComponent, canActivate: [AuthGuard], data: { memberRole: MemberRoles.Moderator } },
{ path: "members/:memberId", component: ProfileComponent }, { path: "members/:memberId", component: ProfileComponent },
{ path: "auto-roles", loadChildren: () => import("./auto-role/auto-role.module").then(m => m.AutoRoleModule) }, {
{ path: "levels", loadChildren: () => import("./levels/levels.module").then(m => m.LevelsModule) }, path: "auto-roles",
{ path: "achievements", loadChildren: () => import("./achievements/achievements.module").then(m => m.AchievementsModule) }, loadChildren: () => import("./auto-role/auto-role.module").then(m => m.AutoRoleModule),
{ path: "config", loadChildren: () => import("./config/config.module").then(m => m.ConfigModule) } canActivate: [AuthGuard],
data: { memberRole: MemberRoles.Moderator }
},
{ path: "levels", loadChildren: () => import("./levels/levels.module").then(m => m.LevelsModule), canActivate: [AuthGuard], data: { memberRole: MemberRoles.Moderator } },
{ path: "achievements", loadChildren: () => import("./achievements/achievements.module").then(m => m.AchievementsModule), data: { memberRole: MemberRoles.Moderator } },
{ path: "config", loadChildren: () => import("./config/config.module").then(m => m.ConfigModule), data: { memberRole: MemberRoles.Admin } }
]; ];
@NgModule({ @NgModule({

View File

@ -2,6 +2,6 @@
"WebVersion": { "WebVersion": {
"Major": "1", "Major": "1",
"Minor": "1", "Minor": "1",
"Micro": "0.rc2" "Micro": "0.rc3"
} }
} }