Optimized code #133

kdb-web/src/app/services/data/data.service.ts

@@ -28,7 +28,7 @@ export class DataService {
   public getServerFromRoute(route: ActivatedRoute): Promise<Server> {
     return new Promise((resolve, reject) => {
       this.spinner.showSpinner();
-      if (!route.snapshot.params["serverId"]) {
+      if (!route.snapshot.params["serverId"] || route.snapshot.params["serverId"] == "undefined") {
         this.spinner.hideSpinner();
         this.router.navigate(["/dashboard"]);
         reject();

kdb-web/src/app/services/sidebar/sidebar.service.ts

@@ -18,17 +18,16 @@ export class SidebarService {
   menuItems$ = new BehaviorSubject<MenuItem[]>(new Array<MenuItem>());
   server$ = new BehaviorSubject<Server | null>(null);
 
-  dashboard!: MenuItem;
-  serverDashboard!: MenuItem;
-  serverProfile!: MenuItem;
-  serverMembers!: MenuItem;
-  serverAutoRoles!: MenuItem;
-  serverAutoRoleRules!: MenuItem;
-  serverLevels!: MenuItem;
-  serverMenu!: MenuItem;
-  adminConfig!: MenuItem;
-  adminUsers!: MenuItem;
-  adminMenu!: MenuItem;
+  dashboard: MenuItem = {};
+  serverDashboard: MenuItem = {};
+  serverProfile: MenuItem = {};
+  serverMembers: MenuItem = {};
+  serverAutoRoles: MenuItem = {};
+  serverLevels: MenuItem = {};
+  serverMenu: MenuItem = {};
+  adminConfig: MenuItem = {};
+  adminUsers: MenuItem = {};
+  adminMenu: MenuItem = {};
 
   constructor(
     private themeService: ThemeService,

kdb-web/src/app/services/theme/theme.service.ts

@@ -12,7 +12,6 @@ export class ThemeService {
 
   sidebarWidth = '150px';
   isSidebarOpen = false;
-  hasLangChanged = false;
 
   themeName$ = new BehaviorSubject<string>(Themes.Default);
   isSidebarOpen$ = new BehaviorSubject<boolean>(true);