sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

1.0.0.rc1 #244

Merged
edraft merged 14 commits from 1.0.0.rc1 into 1.0.0 2023-03-11 01:12:31 +01:00
Conversation 0 Commits 14 Files Changed 102 +221 -197
edraft commented 2023-03-05 21:49:24 +01:00
Owner
Copy Link
No description provided.
edraft added 12 commits 2023-03-05 21:49:25 +01:00
edraft self-assigned this 2023-03-05 21:49:28 +01:00
edraft added this to the Sprint 1.0.0 project 2023-03-05 21:56:14 +01:00
edraft added this to the Sprint 1.0.0 milestone 2023-03-05 21:56:16 +01:00
edraft force-pushed 1.0.0.rc1 from 2a458d3460 to 3721c6c246 2023-03-06 08:10:34 +01:00 Compare
edraft force-pushed 1.0.0.rc1 from 3721c6c246 to 21cfa5c524 2023-03-06 08:11:27 +01:00 Compare
edraft changed title from WIP: 1.0.0.rc1 to 1.0.0.rc1 2023-03-06 08:42:35 +01:00
edraft force-pushed 1.0.0.rc1 from 9c23ec533d to 128e3f06a2 2023-03-06 08:42:49 +01:00 Compare
edraft changed title from 1.0.0.rc1 to WIP: 1.0.0.rc1 2023-03-06 08:42:59 +01:00
edraft changed title from WIP: 1.0.0.rc1 to 1.0.0.rc1 2023-03-06 08:44:20 +01:00
edraft force-pushed 1.0.0.rc1 from 128e3f06a2 to 21f0f32322 2023-03-06 10:55:20 +01:00 Compare
edraft requested review from Ebola-Chan 2023-03-06 10:57:45 +01:00
edraft added the
release
 label 2023-03-06 10:57:52 +01:00
edraft added 1 commit 2023-03-09 19:28:00 +01:00
edraft added 1 commit 2023-03-09 19:41:16 +01:00
Ebola-Chan requested changes 2023-03-09 23:35:45 +01:00
Dismissed
kdb-bot/src/bot_data/model/user_joined_game_server.py
@ -43,2 +43,4 @@
def time(self) -> float:
if self._leaved_on is None or self._joined_on is None:
return 0
return round((self.leaved_on - self.joined_on).total_seconds() / 3600, 2)
Ebola-Chan commented 2023-03-09 23:32:02 +01:00
Contributor
Copy Link

Folgende Frage: Wenn ein User innerhalb einer Sekunde joined und leaved, kann hier nicht durch 0 geteilt werden? Es könnte sein, dass durch die Millisekunden automatisch 1 Sekunde durch total_seconds() ausgegeben wird.

Folgende Frage: Wenn ein User innerhalb einer Sekunde joined und leaved, kann hier nicht durch 0 geteilt werden? Es könnte sein, dass durch die Millisekunden automatisch 1 Sekunde durch ```total_seconds()``` ausgegeben wird.
edraft commented 2023-03-10 11:16:19 +01:00
Author
Owner
Copy Link

Passt:

round((datetime.strptime("2023-03-09 19:37:30.170896", "%Y-%m-%d %H:%M:%S.%f") - datetime.strptime("2023-03-09 19:37:30.170896", "%Y-%m-%d %H:%M:%S.%f")).total_seconds() / 3600, 2) = 0.0
Passt: ```py round((datetime.strptime("2023-03-09 19:37:30.170896", "%Y-%m-%d %H:%M:%S.%f") - datetime.strptime("2023-03-09 19:37:30.170896", "%Y-%m-%d %H:%M:%S.%f")).total_seconds() / 3600, 2) = 0.0 ```
edraft marked this conversation as resolved
kdb-bot/src/bot_data/model/user_joined_voice_channel.py
@ -49,2 +49,4 @@
def time(self) -> float:
if self._leaved_on is None or self._joined_on is None:
return 0
return round((self.leaved_on - self.joined_on).total_seconds() / 3600, 2)
Ebola-Chan commented 2023-03-09 23:32:45 +01:00
Contributor
Copy Link

Hier auch die selbe Frage mit durch 0 dividieren.

Hier auch die selbe Frage mit durch 0 dividieren.
edraft marked this conversation as resolved
edraft requested review from Ebola-Chan 2023-03-10 11:16:24 +01:00
edraft removed review request for Ebola-Chan 2023-03-11 01:10:30 +01:00
edraft requested review from edraft-dev 2023-03-11 01:10:40 +01:00
edraft-dev approved these changes 2023-03-11 01:11:55 +01:00
edraft-dev left a comment
Owner
Copy Link

Approved for @Ebola-Chan

Approved for @Ebola-Chan
edraft dismissed Ebola-Chan’s review 2023-03-11 01:12:19 +01:00
Reason:

Inaktiv

edraft merged commit 7966ca16e5 into 1.0.0 2023-03-11 01:12:31 +01:00
edraft deleted branch 1.0.0.rc1 2023-03-11 01:12:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Ebola-Chan
edraft-dev
Labels
Clear labels   
MVP

   
web-interface
  
bug

Something is not working

  
bugfix

Solution of a problem

  
cli

Changes for command line interface

  
discussion

Something needs to be discussed

  
documentation

Indicates a need for improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
expense
high

  
expense
low

  
expense
medium

  
expense
very-high

  
help wanted

Need some help

  
improvement

Improvement of a feature

  
invalid

Something is wrong

  
priority
blocker

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
refactoring

Code need some refactoring

  
release

Create a release

  
story

New feature

  
wontfix

This won't be fixed

No Label
MVP
web-interface
bug
bugfix
cli
discussion
documentation
duplicate
expense
high
expense
low
expense
medium
expense
very-high
help wanted
improvement
invalid
priority
blocker
priority
high
priority
low
priority
medium
question
refactoring
release
story
wontfix
Milestone
Clear milestone
No items
No Milestone
Sprint 1.0.0
Projects
Clear projects
No project
Sprint 1.0.0
Assignees
Clear assignees
No Assignees
edraft
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sh-edraft.de/sh_discord_bot#244
No description provided.
Delete Branch "1.0.0.rc1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?