sh-edraft.de/sh_discord_bot
4
1
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects 3 Releases 27 Wiki Activity

#133 #224

Merged
Jonas merged 7 commits from #133 into 1.0.0 2023-02-22 19:29:16 +01:00
Conversation 0 Commits 7 Files Changed 28 +777 -96
edraft commented 2023-02-21 10:04:25 +01:00
Owner
Copy Link

push von jonas ausstehend

push von jonas ausstehend
edraft self-assigned this 2023-02-21 10:04:25 +01:00
edraft changed title from #133 to WIP: #133 2023-02-21 10:04:28 +01:00
edraft requested review from edraft-dev 2023-02-21 10:04:32 +01:00
edraft added this to the Sprint 1.0.0 project 2023-02-21 10:04:35 +01:00
Jonas added 1 commit 2023-02-21 16:58:56 +01:00
edraft force-pushed #133 from 73747dfee1 to f3024d2ea5 2023-02-21 17:24:22 +01:00 Compare
edraft changed title from WIP: #133 to #133 2023-02-21 17:24:42 +01:00
edraft requested review from Jonas 2023-02-21 17:24:47 +01:00
edraft added 1 commit 2023-02-21 17:29:11 +01:00
edraft-dev approved these changes 2023-02-21 17:29:49 +01:00
Jonas reviewed 2023-02-21 21:06:36 +01:00
kdb-web/src/app/modules/view/server/levels/components/levels/levels.component.html Outdated
@ -0,0 +78,4 @@
<th>
<div class="table-header-label">
<div class="table-header-text">{{'view.server.members.headers.actions' | translate}}</div>
Jonas commented 2023-02-21 21:06:36 +01:00
Contributor
Copy Link

Falsche Translation. In der Level-Komponente erwarte ich als Pfad 'view.server.levels.headers.actions'.

Falsche Translation. In der Level-Komponente erwarte ich als Pfad 'view.server.**levels**.headers.actions'.
edraft marked this conversation as resolved
Jonas requested changes 2023-02-21 21:21:41 +01:00
kdb-web/src/app/modules/view/server/levels/components/levels/levels.component.ts
@ -0,0 +20,4 @@
import { LevelMutationResult, UpdateUserMutationResult } from "../../../../../../models/graphql/result.model";
import { Mutations } from "../../../../../../models/graphql/mutations.model";
import { throwError } from "rxjs";
Jonas commented 2023-02-21 21:16:55 +01:00
Contributor
Copy Link

Ich empfehle die Dependency für @UntilDestroy, damit alle Subscribes unsubscribt werden, sobald die Component stirbt.
Kann merkwürdige und schwer nachvollziehe Bugs verhindern und die Performance der Anwendung erhöhen.

Siehe (Dependency:

https://www.npmjs.com/package/@ngneat/until-destroy/v/7.1.5

Und (Warum Unsubscriben wichtig sein könnte):

https://www.learmoreseekmore.com/2021/11/why-we-have-to-unsubscribe-an-observable-in-angular-application.html

Ich empfehle die Dependency für **@UntilDestroy**, damit alle Subscribes unsubscribt werden, sobald die Component stirbt. Kann merkwürdige und schwer nachvollziehe Bugs verhindern und die Performance der Anwendung erhöhen. Siehe (Dependency: https://www.npmjs.com/package/@ngneat/until-destroy/v/7.1.5 Und (Warum Unsubscriben wichtig sein könnte): https://www.learmoreseekmore.com/2021/11/why-we-have-to-unsubscribe-an-observable-in-angular-application.html
edraft commented 2023-02-21 22:45:18 +01:00
Author
Owner
Copy Link

Gibt native wege, sind implementiert

Gibt native wege, sind implementiert
Jonas marked this conversation as resolved
kdb-web/src/app/modules/view/server/levels/components/levels/levels.component.ts Outdated
@ -0,0 +38,4 @@
name: FormControl<string | null>,
color: FormControl<string | null>,
min_xp: FormControl<number | null>,
permissions: FormControl<number | null>,
Jonas commented 2023-02-21 21:11:21 +01:00
Contributor
Copy Link

War permissions nicht doch ein string?

War permissions nicht doch ein string?
edraft marked this conversation as resolved
kdb-web/src/app/modules/view/server/levels/components/levels/levels.component.ts Outdated
@ -0,0 +93,4 @@
name: new FormControl<string | null>(null),
color: new FormControl<string | null>(null),
min_xp: new FormControl<number | null>(null),
permissions: new FormControl<number | null>(null)
Jonas commented 2023-02-21 21:18:00 +01:00
Contributor
Copy Link

Siehe Kommentar bei Zeile 41.

Siehe Kommentar bei Zeile 41.
edraft marked this conversation as resolved
kdb-web/src/assets/i18n/de.json
@ -284,0 +285,4 @@
},
"levels": {
"header": "Level",
"reset_filters": "Filter zurücksetzen",
Jonas commented 2023-02-21 21:20:39 +01:00
Contributor
Copy Link

Auslagern.

Auslagern.
edraft marked this conversation as resolved
kdb-web/src/assets/i18n/de.json
@ -284,0 +286,4 @@
"levels": {
"header": "Level",
"reset_filters": "Filter zurücksetzen",
"of": "von",
Jonas commented 2023-02-21 21:20:42 +01:00
Contributor
Copy Link

Auslagern.

Auslagern.
edraft marked this conversation as resolved
kdb-web/src/assets/i18n/de.json
@ -284,0 +287,4 @@
"header": "Level",
"reset_filters": "Filter zurücksetzen",
"of": "von",
"add": "Hinzufügen",
Jonas commented 2023-02-21 21:20:45 +01:00
Contributor
Copy Link

Auslagern.

Auslagern.
edraft marked this conversation as resolved
kdb-web/src/assets/i18n/de.json
@ -284,0 +296,4 @@
"min_xp": "Min. XP",
"permissions": "Rechte"
},
"no_entries_found": "Keine Einträge gefunden",
Jonas commented 2023-02-21 21:20:52 +01:00
Contributor
Copy Link

Auslagern.

Auslagern.
edraft commented 2023-02-21 21:32:34 +01:00
Author
Owner
Copy Link

Im nachgang für alle Probleme sh-edraft.de/kd_discord_bot#232

Im nachgang für alle Probleme https://git.sh-edraft.de/sh-edraft.de/kd_discord_bot/issues/232
Jonas marked this conversation as resolved
edraft added 1 commit 2023-02-21 22:44:51 +01:00
edraft added 1 commit 2023-02-21 22:45:31 +01:00
edraft added a new dependency 2023-02-22 08:48:45 +01:00
#220 Tabellen fixen
edraft requested review from Jonas 2023-02-22 17:10:33 +01:00
Jonas refused to review 2023-02-22 19:28:30 +01:00
Jonas approved these changes 2023-02-22 19:29:07 +01:00
Jonas merged commit 42b71525bd into 1.0.0 2023-02-22 19:29:16 +01:00
Jonas deleted branch #133 2023-02-22 19:29:16 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
edraft-dev
Jonas
Labels
Clear labels   
MVP

   
web-interface
  
bug

Something is not working

  
bugfix

Solution of a problem

  
cli

Changes for command line interface

  
discussion

Something needs to be discussed

  
documentation

Indicates a need for improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
expense
high

  
expense
low

  
expense
medium

  
expense
very-high

  
help wanted

Need some help

  
improvement

Improvement of a feature

  
invalid

Something is wrong

  
priority
blocker

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
refactoring

Code need some refactoring

  
release

Create a release

  
story

New feature

  
wontfix

This won't be fixed

No Label
MVP
web-interface
bug
bugfix
cli
discussion
documentation
duplicate
expense
high
expense
low
expense
medium
expense
very-high
help wanted
improvement
invalid
priority
blocker
priority
high
priority
low
priority
medium
question
refactoring
release
story
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Sprint 1.0.0
Assignees
Clear assignees
No Assignees
edraft
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#220 Tabellen fixen
sh-edraft.de/sh_discord_bot
Reference: sh-edraft.de/sh_discord_bot#224
No description provided.
Delete Branch "#133"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?