New implementation of scopes #186

src/cpl-core/cpl/core/utils/string.py

@@ -114,12 +114,15 @@ class String:
 
         characters = []
         if letters:
-            characters.append(string.ascii_letters)
+            characters.extend(string.ascii_letters)
 
         if digits:
-            characters.append(string.digits)
+            characters.extend(string.digits)
 
         if special_characters:
-            characters.append(string.punctuation)
+            characters.extend(string.punctuation)
 
-        return "".join(random.choice(characters) for _ in range(length)) if characters else ""
+        x = "".join(random.choice(list(characters)) for _ in range(length)) if characters else ""
+        if len(x) != length:
+            raise Exception("No characters selected to generate random string")
+        return x