sh-edraft.de/actions
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added package filtering
Some checks failed
Build on push / prepare (push) Successful in 5s
Details
Build on push / build (push) Failing after 15s
Details

Browse Source
This commit is contained in:
Sven Heidemann
2026-02-14 20:48:34 +01:00
parent 5e493513f1
commit 98abbe661c
23 changed files with 2072 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

617
sh.actions.package-cleanup.Tests/Service/PackageServiceDateVersionTests.cs Normal file
View File

@@ -0,0 +1,617 @@
using Microsoft.Extensions.Configuration;
using Moq;
using sh.actions.package_cleanup.Models;
using sh.actions.package_cleanup.Service;
using Xunit;
namespace sh.actions.package_cleanup.Tests.Service;
public class PackageServiceDateVersionTests
{
private Mock<IConfiguration> _configurationMock;
private Mock<IGiteaPackageService> _giteaPackageServiceMock;
private IPackageService _packageService;
private void SetupMocks()
{
_configurationMock = new Mock<IConfiguration>();
_giteaPackageServiceMock = new Mock<IGiteaPackageService>();
_packageService = new PackageService(_configurationMock.Object, _giteaPackageServiceMock.Object);
}
// ...existing code...
#region Version Detection Tests
[Theory]
[InlineData("2024.12.25.1")]
[InlineData("2025.2.14.1")]
[InlineData("2026.1.1.100")]
[InlineData("2023.12.31.999")]
public void FilterPackagesToDelete_WithDateVersions_ShouldIdentifyCorrectly(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Single prod date version should not be deleted
Assert.NotNull(result);
Assert.Empty(result);
}
[Theory]
[InlineData("2024.12.25.1-dev")]
[InlineData("2025.2.14.1-alpha")]
[InlineData("2026.1.1.100-beta")]
[InlineData("2023.12.31.999-rc")]
public void FilterPackagesToDelete_WithDateVersionsAndSuffixes_ShouldIdentifyCorrectly(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Single prerelease/dev date version should be kept
Assert.NotNull(result);
Assert.Empty(result);
}
#endregion
#region Prod Release Tests - Date Versioning
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithOnlyProdReleases_ShouldReturnEmpty()
{
// Arrange - CLEAN_PROD_VERSIONS not set, defaults to false
SetupMocks();
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2025.12.20.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-30)
},
new()
{
Id = 2, Name = "test", Version = "2025.12.25.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-20)
},
new()
{
Id = 3, Name = "test", Version = "2026.1.5.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10)
}
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Prod releases should be protected by default (CLEAN_PROD_VERSIONS=false)
Assert.Empty(result);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithProdReleasesAndCleaningEnabled_ShouldDeleteOldest()
{
// Arrange
SetupMocks();
_configurationMock.Setup(c => c["CLEAN_PROD_VERSIONS"]).Returns("true");
_configurationMock.Setup(c => c["KEEP_PROD_VERSIONS"]).Returns("2");
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2025.1.1.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-365)
},
new()
{
Id = 2, Name = "test", Version = "2025.6.15.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-200)
},
new()
{
Id = 3, Name = "test", Version = "2026.1.1.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-45)
},
new() { Id = 4, Name = "test", Version = "2026.2.14.1", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete oldest 2 (2025.1.1 and 2025.6.15), keep newest 2
Assert.Equal(2, result.Count);
Assert.Contains(result, p => p.Id == 1);
Assert.Contains(result, p => p.Id == 2);
Assert.DoesNotContain(result, p => p.Id == 3 || p.Id == 4);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithMultipleProdVersions_ShouldKeepNewest()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2025.1.1.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-365)
},
new()
{
Id = 2, Name = "test", Version = "2025.6.15.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-200)
},
new()
{
Id = 3, Name = "test", Version = "2026.1.1.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-45)
},
new() { Id = 4, Name = "test", Version = "2026.2.14.1", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default is CLEAN_PROD_VERSIONS=false, so nothing should be deleted
Assert.Empty(result);
}
#endregion
#region Prerelease Tests - Date Versioning
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithPrereleaseVersions_ShouldKeepLatest()
{
// Arrange - Default KEEP_PRERELEASE_VERSIONS=3
SetupMocks();
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2026.2.10.1-alpha", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-5)
},
new()
{
Id = 2, Name = "test", Version = "2026.2.11.1-beta", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-4)
},
new()
{
Id = 3, Name = "test", Version = "2026.2.12.1-rc", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-3)
},
new()
{
Id = 4, Name = "test", Version = "2026.2.13.1-preview", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-2)
}
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete oldest 1 (alpha), keep newest 3
Assert.Single(result);
Assert.Contains(result, p => p.Id == 1); // alpha is oldest
Assert.DoesNotContain(result, p => p.Id == 2 || p.Id == 3 || p.Id == 4);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithManyPrereleases_ShouldEnforceLimit()
{
// Arrange - Custom KEEP_PRERELEASE_VERSIONS=2
SetupMocks();
_configurationMock.Setup(c => c["KEEP_PRERELEASE_VERSIONS"]).Returns("2");
var packages = new List<GiteaPackage>();
for (int i = 0; i < 10; i++)
{
var date = DateTime.UtcNow.AddDays(-i);
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"{date.Year}.{date.Month}.{date.Day}.{i}-beta",
Type = "docker",
CreatedAt = date
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete 8 oldest, keep only 2 newest (Id=0,1)
Assert.Equal(8, result.Count);
Assert.DoesNotContain(result, p => p.Id < 2);
Assert.Contains(result, p => p.Id >= 2);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithMixedPrereleases_ShouldOrderByDate()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2025.12.1.1-beta", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-60)
},
new()
{
Id = 2, Name = "test", Version = "2026.1.15.1-beta", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-30)
},
new()
{
Id = 3, Name = "test", Version = "2026.2.1.1-alpha", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-14)
}
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default keep 3, so all should be kept
Assert.Empty(result);
}
#endregion
#region Dev Release Tests - Date Versioning
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithDevVersions_ShouldKeepLatest()
{
// Arrange - Default KEEP_DEV_VERSIONS=5
SetupMocks();
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2026.2.10.1-dev", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-5)
},
new()
{
Id = 2, Name = "test", Version = "2026.2.11.2-dev", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-4)
},
new()
{
Id = 3, Name = "test", Version = "2026.2.12.3-dev", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-3)
}
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default keep 5, so all 3 should be kept
Assert.Empty(result);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithManyDailyDevReleases_ShouldEnforceLimit()
{
// Arrange - Custom KEEP_DEV_VERSIONS=3
SetupMocks();
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("3");
var packages = new List<GiteaPackage>();
for (int i = 0; i < 30; i++)
{
var date = DateTime.UtcNow.AddDays(-i);
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"{date.Year}.{date.Month}.{date.Day}.{i}-dev",
Type = "docker",
CreatedAt = date
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete 27 oldest, keep only 3 newest (Id=0,1,2)
Assert.Equal(27, result.Count);
Assert.DoesNotContain(result, p => p.Id < 3);
Assert.Contains(result, p => p.Id >= 3);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithManyDailyDevReleasesDefaultLimit_ShouldIdentifyAll()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>();
for (int i = 0; i < 30; i++)
{
var date = DateTime.UtcNow.AddDays(-i);
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"{date.Year}.{date.Month}.{date.Day}.{i}-dev",
Type = "docker",
CreatedAt = date
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default keep 5, so 25 should be deleted
Assert.Equal(25, result.Count);
Assert.DoesNotContain(result, p => p.Id < 5); // Keep newest 5 (Id 0-4)
Assert.Contains(result, p => p.Id >= 5);
}
#endregion
#region Mixed Release Types - Date Versioning
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithMixedReleaseTypes_ShouldSeparateAndCleanCorrectly()
{
// Arrange
SetupMocks();
_configurationMock.Setup(c => c["KEEP_PRERELEASE_VERSIONS"]).Returns("2");
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("2");
var packages = new List<GiteaPackage>
{
// Prod releases (should not be deleted - CLEAN_PROD_VERSIONS=false)
new()
{
Id = 1, Name = "test", Version = "2025.12.1.1", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-80)
},
new()
{
Id = 2, Name = "test", Version = "2026.1.1.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-45)
},
// Prerelease (keep 2 newest)
new()
{
Id = 3, Name = "test", Version = "2026.1.25.1-alpha", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-20)
},
new()
{
Id = 4, Name = "test", Version = "2026.2.1.1-beta", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-14)
},
new()
{
Id = 5, Name = "test", Version = "2026.2.5.1-rc", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-10)
},
// Dev (keep 2 newest)
new()
{
Id = 6, Name = "test", Version = "2026.2.10.1-dev", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-5)
},
new() { Id = 7, Name = "test", Version = "2026.2.14.1-dev", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.Equal(1, result.Count); // Should delete 1 prerelease (alpha), 0 dev (keep both)
Assert.DoesNotContain(result, p => p.Id <= 2); // Prod not deleted
Assert.DoesNotContain(result, p => p.Id >= 6); // Keep 2 latest dev
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithLargeSet_ShouldHandleCorrectly()
{
// Arrange
SetupMocks();
_configurationMock.Setup(c => c["CLEAN_PROD_VERSIONS"]).Returns("false");
_configurationMock.Setup(c => c["KEEP_PRERELEASE_VERSIONS"]).Returns("3");
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("5");
var packages = new List<GiteaPackage>();
// Add prod releases
for (int i = 0; i < 5; i++)
{
var date = DateTime.UtcNow.AddMonths(-(5 - i));
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"{date.Year}.{date.Month}.1.1",
Type = "docker",
CreatedAt = date
});
}
// Add prerelease
for (int i = 5; i < 15; i++)
{
var date = DateTime.UtcNow.AddDays(-(15 - i) * 7);
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"{date.Year}.{date.Month}.{date.Day}.1-beta",
Type = "docker",
CreatedAt = date
});
}
// Add dev
for (int i = 15; i < 30; i++)
{
var date = DateTime.UtcNow.AddDays(-(30 - i));
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"{date.Year}.{date.Month}.{date.Day}.{(30 - i)}-dev",
Type = "docker",
CreatedAt = date
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.NotNull(result);
// Prod releases should never be deleted
Assert.DoesNotContain(result, p => p.Id < 5);
// Should delete 7 oldest prerelease (keep 3 newest)
var prereleaseDeleted = result.Where(p => p.Id >= 5 && p.Id < 15).ToList();
Assert.Equal(7, prereleaseDeleted.Count);
// Should delete 10 oldest dev (keep 5 newest)
var devDeleted = result.Where(p => p.Id >= 15).ToList();
Assert.Equal(10, devDeleted.Count);
}
#endregion
#region Edge Cases - Date Versioning
[Theory]
[InlineData("1000.1.1.1")] // Minimum valid year
[InlineData("2999.12.31.999")] // Maximum valid year
[InlineData("2025.2.14.0")] // Build number 0
public void FilterPackagesToDeleteByDateVersion_WithBoundaryVersions_ShouldHandleCorrectly(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.NotNull(result);
}
[Theory]
[InlineData("999.12.31.1")] // Year too small
[InlineData("3000.1.1.1")] // Year too large
[InlineData("2025.13.1.1")] // Month out of range
[InlineData("2025.0.1.1")] // Month zero
[InlineData("2025.2.32.1")] // Day out of range
[InlineData("2025.2.0.1")] // Day zero
public void FilterPackagesToDelete_WithInvalidDateVersions_ShouldNotProcess(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow },
new() { Id = 2, Name = "test", Version = "1.0.0.1", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Invalid date version should be skipped, only semantic version processed
Assert.NotNull(result);
}
[Fact]
public void FilterPackagesToDeleteByDateVersion_WithConsecutiveDates_ShouldOrderCorrectly()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new()
{
Id = 1, Name = "test", Version = "2025.2.10.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-5)
},
new()
{
Id = 2, Name = "test", Version = "2025.2.11.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-4)
},
new()
{
Id = 3, Name = "test", Version = "2025.2.12.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-3)
},
new()
{
Id = 4, Name = "test", Version = "2025.2.13.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-2)
},
new() { Id = 5, Name = "test", Version = "2025.2.14.1", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.NotNull(result);
}
#endregion
#region Mixed Versioning Variants
[Fact]
public void FilterPackagesToDelete_WithMixedVersioningVariants_ShouldProcessBothTypes()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
// Semantic versioning
new()
{
Id = 1, Name = "test", Version = "1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-30)
},
new()
{
Id = 2, Name = "test", Version = "1.1.0-dev", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10)
},
// Date versioning
new()
{
Id = 3, Name = "test", Version = "2025.1.1.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-45)
},
new()
{
Id = 4, Name = "test", Version = "2025.2.10.1-dev", Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-5)
}
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.NotNull(result);
// Prod releases should not be in delete list
Assert.DoesNotContain(result, p => p.Id == 1 || p.Id == 3);
}
#endregion
}

498
sh.actions.package-cleanup.Tests/Service/PackageServiceSemanticVersionTests.cs Normal file
View File

@@ -0,0 +1,498 @@
using Microsoft.Extensions.Configuration;
using Moq;
using sh.actions.package_cleanup.Models;
using sh.actions.package_cleanup.Service;
using Xunit;
namespace sh.actions.package_cleanup.Tests.Service;
public class PackageServiceSemanticVersionTests
{
private Mock<IConfiguration> _configurationMock;
private Mock<IGiteaPackageService> _giteaPackageServiceMock;
private IPackageService _packageService;
private void SetupMocks()
{
_configurationMock = new Mock<IConfiguration>();
_giteaPackageServiceMock = new Mock<IGiteaPackageService>();
_packageService = new PackageService(_configurationMock.Object, _giteaPackageServiceMock.Object);
}
#region Version Detection Tests
[Theory]
[InlineData("1.0.0.0")]
[InlineData("2.5.3.1")]
[InlineData("10.20.30.100")]
[InlineData("1.0.0")]
[InlineData("2.5")]
public void FilterPackagesToDelete_WithSemanticVersions_ShouldIdentifyCorrectly(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Single prod version should not be deleted (CLEAN_PROD_VERSIONS=false by default)
Assert.NotNull(result);
Assert.Empty(result);
}
[Theory]
[InlineData("1.0.0.0-dev")]
[InlineData("2.5.3.1-alpha")]
[InlineData("10.20.30.100-beta")]
[InlineData("1.0.0-rc1")]
[InlineData("2.5-preview")]
public void FilterPackagesToDelete_WithSemanticVersionsAndSuffixes_ShouldIdentifyCorrectly(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Single prerelease/dev should be kept
Assert.NotNull(result);
Assert.Empty(result);
}
#endregion
#region Prod Release Tests - Semantic Versioning
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithOnlyProdReleases_ShouldReturnEmpty()
{
// Arrange - CLEAN_PROD_VERSIONS not set, defaults to false
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-30) },
new() { Id = 2, Name = "test", Version = "1.1.0.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-20) },
new() { Id = 3, Name = "test", Version = "1.2.0.1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10) }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Prod releases should be protected by default (CLEAN_PROD_VERSIONS=false)
Assert.Empty(result);
Assert.DoesNotContain(result, p => p.Id == 1 || p.Id == 2 || p.Id == 3);
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithProdReleasesAndCleaningEnabled_ShouldDeleteOldest()
{
// Arrange
SetupMocks();
_configurationMock.Setup(c => c["CLEAN_PROD_VERSIONS"]).Returns("true");
_configurationMock.Setup(c => c["KEEP_PROD_VERSIONS"]).Returns("2");
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-30) },
new() { Id = 2, Name = "test", Version = "1.1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-20) },
new() { Id = 3, Name = "test", Version = "2.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10) },
new() { Id = 4, Name = "test", Version = "2.1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete oldest 2 (1.0.0.0 and 1.1.0.0), keep newest 2 (2.0.0.0 and 2.1.0.0)
Assert.Equal(2, result.Count);
Assert.Contains(result, p => p.Id == 1);
Assert.Contains(result, p => p.Id == 2);
Assert.DoesNotContain(result, p => p.Id == 3 || p.Id == 4);
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithMultipleProdVersions_ShouldKeepNewest()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-30) },
new() { Id = 2, Name = "test", Version = "1.0.1.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-20) },
new() { Id = 3, Name = "test", Version = "2.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10) },
new() { Id = 4, Name = "test", Version = "2.1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default is CLEAN_PROD_VERSIONS=false, so nothing should be deleted
Assert.Empty(result);
}
#endregion
#region Prerelease Tests - Semantic Versioning
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithPrereleaseVersions_ShouldKeepLatest()
{
// Arrange - Default KEEP_PRERELEASE_VERSIONS=3
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0-alpha", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-5) },
new() { Id = 2, Name = "test", Version = "1.0.0-beta", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-4) },
new() { Id = 3, Name = "test", Version = "1.0.0-rc1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-3) },
new() { Id = 4, Name = "test", Version = "1.0.0-preview", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-2) }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete oldest 1 (alpha, id=1), keep newest 3 (beta, rc1, preview)
Assert.Single(result);
Assert.Contains(result, p => p.Id == 1); // alpha is oldest, should be deleted
Assert.DoesNotContain(result, p => p.Id == 2 || p.Id == 3 || p.Id == 4); // Keep newest 3
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithManyPrereleases_ShouldEnforceLimit()
{
// Arrange - Custom KEEP_PRERELEASE_VERSIONS=2
SetupMocks();
_configurationMock.Setup(c => c["KEEP_PRERELEASE_VERSIONS"]).Returns("2");
var packages = new List<GiteaPackage>();
for (int i = 0; i < 10; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"1.0.0-beta{i}",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-(10 - i))
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete 8 oldest, keep only 2 newest (Id=8,9)
Assert.Equal(8, result.Count);
Assert.DoesNotContain(result, p => p.Id >= 8);
Assert.Contains(result, p => p.Id < 8);
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithMixedPrereleases_ShouldOrderByVersion()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0-beta", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10) },
new() { Id = 2, Name = "test", Version = "2.0.0-beta", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-5) },
new() { Id = 3, Name = "test", Version = "1.5.0-alpha", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-3) }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default keep 3, so all should be kept
Assert.Empty(result);
}
#endregion
#region Dev Release Tests - Semantic Versioning
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithDevVersions_ShouldKeepLatest()
{
// Arrange - Default KEEP_DEV_VERSIONS=5
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0-dev", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-5) },
new() { Id = 2, Name = "test", Version = "1.0.1-dev", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-4) },
new() { Id = 3, Name = "test", Version = "2.0.0-dev", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-3) }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default keep 5, so all 3 should be kept
Assert.Empty(result);
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithManyDevReleases_ShouldEnforceLimit()
{
// Arrange - Custom KEEP_DEV_VERSIONS=3
SetupMocks();
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("3");
var packages = new List<GiteaPackage>();
for (int i = 0; i < 10; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"1.0.{i}-dev",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-i)
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should delete 7 oldest, keep only 3 newest (Id=7,8,9 are newest by CreatedAt)
Assert.Equal(7, result.Count);
Assert.DoesNotContain(result, p => p.Id >= 7); // Keep newest 3
Assert.Contains(result, p => p.Id < 7); // Delete oldest 7
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithManyDevReleases_ShouldIdentifyAll()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>();
for (int i = 0; i < 20; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"1.0.{i}-dev",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-i)
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Default keep 5, so 15 should be deleted
Assert.Equal(15, result.Count);
Assert.DoesNotContain(result, p => p.Id >= 15); // Keep newest 5 (Id 15-19)
Assert.Contains(result, p => p.Id < 15);
}
#endregion
#region Mixed Release Types - Semantic Versioning
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithMixedReleaseTypes_ShouldSeparateAndCleanCorrectly()
{
// Arrange - CLEAN_PROD_VERSIONS=false, KEEP_PRERELEASE_VERSIONS=2, KEEP_DEV_VERSIONS=2
SetupMocks();
_configurationMock.Setup(c => c["KEEP_PRERELEASE_VERSIONS"]).Returns("2");
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("2");
var packages = new List<GiteaPackage>
{
// Prod releases (should not be deleted - CLEAN_PROD_VERSIONS=false)
new() { Id = 1, Name = "test", Version = "1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-30) },
new() { Id = 2, Name = "test", Version = "1.1.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-25) },
// Prerelease (keep 2 newest)
new() { Id = 3, Name = "test", Version = "1.2.0-alpha", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-20) },
new() { Id = 4, Name = "test", Version = "1.2.0-beta", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-15) },
new() { Id = 5, Name = "test", Version = "1.2.1-rc", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10) },
// Dev (keep 2 newest)
new() { Id = 6, Name = "test", Version = "1.2.1-dev", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-5) },
new() { Id = 7, Name = "test", Version = "1.2.2-dev", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.Equal(1, result.Count); // Should delete 1 prerelease (alpha), 0 dev (keep both)
Assert.DoesNotContain(result, p => p.Id <= 2); // Prod not deleted
Assert.DoesNotContain(result, p => p.Id >= 6); // Keep 2 latest dev
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithLargeSet_ShouldHandleCorrectly()
{
// Arrange
SetupMocks();
_configurationMock.Setup(c => c["CLEAN_PROD_VERSIONS"]).Returns("false");
_configurationMock.Setup(c => c["KEEP_PRERELEASE_VERSIONS"]).Returns("3");
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("5");
var packages = new List<GiteaPackage>();
// Add prod releases
for (int i = 0; i < 5; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"1.{i}.0",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-(5 - i))
});
}
// Add prerelease
for (int i = 5; i < 15; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"2.0.{i - 5}-beta",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-(15 - i))
});
}
// Add dev
for (int i = 15; i < 30; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"2.1.{i - 15}-dev",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-(30 - i))
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert
Assert.NotNull(result);
// Prod releases should never be deleted
Assert.DoesNotContain(result, p => p.Id < 5);
// Should delete 7 oldest prerelease (keep 3 newest)
var prereleaseDeleted = result.Where(p => p.Id >= 5 && p.Id < 15).ToList();
Assert.Equal(7, prereleaseDeleted.Count);
// Should delete 10 oldest dev (keep 5 newest)
var devDeleted = result.Where(p => p.Id >= 15).ToList();
Assert.Equal(10, devDeleted.Count);
}
#endregion
#region Edge Cases - Semantic Versioning
[Theory]
[InlineData("0.0.0.0")]
[InlineData("99.99.99.99")]
[InlineData("100.0.0.0")] // Boundary case - might be detected as date version
public void FilterPackagesToDeleteBySemanticVersion_WithBoundaryVersions_ShouldHandleCorrectly(string version)
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should not throw, and boundary versions should be handled properly
Assert.NotNull(result);
// Versions 0.0.0.0 and 99.99.99.99 are semantic, 100.0.0.0 is likely treated as date (will fail date validation)
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithVersionsHavingDifferentLengths_ShouldHandleCorrectly()
{
// Arrange
SetupMocks();
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-5) },
new() { Id = 2, Name = "test", Version = "1.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-4) },
new() { Id = 3, Name = "test", Version = "1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-3) },
new() { Id = 4, Name = "test", Version = "1.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-2) }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should not throw and should not delete any prod versions
Assert.NotNull(result);
// CLEAN_PROD_VERSIONS=false by default, so all versions should be kept
// Id=1 is invalid (only 1 component), ids 2-4 are valid but prod
var validVersions = new[] { 2, 3, 4 };
foreach (var id in validVersions)
{
Assert.DoesNotContain(result, p => p.Id == id);
}
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithZeroKeepCount_ShouldKeepAll()
{
// Arrange - KEEP_DEV_VERSIONS=0 means keep all
SetupMocks();
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("0");
var packages = new List<GiteaPackage>();
for (int i = 0; i < 10; i++)
{
packages.Add(new GiteaPackage
{
Id = i,
Name = "test",
Version = $"1.0.{i}-dev",
Type = "docker",
CreatedAt = DateTime.UtcNow.AddDays(-i)
});
}
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should keep all (0 means infinite/keep all)
Assert.Empty(result);
Assert.DoesNotContain(result, p => p.Id >= 0); // No packages should be deleted
}
[Fact]
public void FilterPackagesToDeleteBySemanticVersion_WithInvalidConfigValues_ShouldUseDefaults()
{
// Arrange - Set invalid config values
SetupMocks();
_configurationMock.Setup(c => c["KEEP_DEV_VERSIONS"]).Returns("invalid");
_configurationMock.Setup(c => c["CLEAN_PROD_VERSIONS"]).Returns("maybe");
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0-dev", Type = "docker", CreatedAt = DateTime.UtcNow.AddDays(-10) },
new() { Id = 2, Name = "test", Version = "1.0.1-dev", Type = "docker", CreatedAt = DateTime.UtcNow },
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should use defaults (KEEP_DEV_VERSIONS=5, CLEAN_PROD_VERSIONS=false)
// With 2 packages and keep 5, no deletion should happen
Assert.Empty(result);
Assert.DoesNotContain(result, p => p.Id == 1 || p.Id == 2);
}
#endregion
}

349
sh.actions.package-cleanup.Tests/Service/PackageServiceVersionDetectionTests.cs Normal file
View File

@@ -0,0 +1,349 @@
using Microsoft.Extensions.Configuration;
using Moq;
using sh.actions.package_cleanup.Models;
using sh.actions.package_cleanup.Service;
using Xunit;
namespace sh.actions.package_cleanup.Tests.Service;
public class PackageServiceVersionDetectionTests
{
private readonly IPackageService _packageService;
private readonly Mock<IConfiguration> _configurationMock;
private readonly Mock<IGiteaPackageService> _giteaPackageServiceMock;
public PackageServiceVersionDetectionTests()
{
_configurationMock = new Mock<IConfiguration>();
_giteaPackageServiceMock = new Mock<IGiteaPackageService>();
_packageService = new PackageService(_configurationMock.Object, _giteaPackageServiceMock.Object);
}
#region Release Type Detection Tests
[Theory]
[InlineData("1.0.0")]
[InlineData("2.5.3")]
[InlineData("10.20.30")]
[InlineData("2025.2.14.1")]
public void FilterPackagesToDelete_WithProdReleases_ShouldIdentifyAsNonDeletable(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Prod releases should not be in delete list (CLEAN_PROD_VERSIONS=false by default)
Assert.DoesNotContain(result, p => p.Id == 1);
Assert.Empty(result); // No packages should be deleted without CLEAN_PROD_VERSIONS=true
}
[Theory]
[InlineData("1.0.0-alpha")]
[InlineData("1.0.0-ALPHA")]
[InlineData("2.5.3-alpha123")]
[InlineData("1.0.0-beta")]
[InlineData("1.0.0-BETA")]
[InlineData("1.0.0-rc")]
[InlineData("1.0.0-RC1")]
[InlineData("1.0.0-preview")]
[InlineData("1.0.0-PREVIEW")]
public void FilterPackagesToDelete_WithPrereleaseVersions_ShouldIdentifyCorrectly(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Prerelease should be kept (default KEEP_PRERELEASE_VERSIONS=3, so 1 package is kept)
Assert.NotNull(result);
Assert.Empty(result); // Single prerelease should be kept as it's within the limit
}
[Theory]
[InlineData("1.0.0-dev")]
[InlineData("1.0.0-DEV")]
[InlineData("2.5.3-dev123")]
[InlineData("1.0.0-development")]
[InlineData("1.0.0-DEV")]
public void FilterPackagesToDelete_WithDevVersions_ShouldIdentifyCorrectly(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Dev version should be kept (default KEEP_DEV_VERSIONS=5, so 1 package is kept)
Assert.NotNull(result);
Assert.Empty(result); // Single dev version should be kept as it's within the limit
}
#endregion
#region Semantic Version Detection Tests
[Theory]
[InlineData("1.0")]
[InlineData("1.0.0")]
[InlineData("1.0.0.0")]
[InlineData("2.5")]
[InlineData("2.5.3")]
[InlineData("2.5.3.100")]
[InlineData("0.0.0.0")]
[InlineData("99.99.99.99")]
public void FilterPackagesToDelete_WithValidSemanticVersions_ShouldProcess(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should process without throwing and not delete prod releases
Assert.NotNull(result);
Assert.DoesNotContain(result, p => p.Id == 1); // Prod version should not be deleted
}
[Theory]
[InlineData("1")] // Only 1 component
[InlineData("1.0.0.0.0")] // 5 components
[InlineData("1.a.0.0")] // Non-numeric
[InlineData("a.b.c.d")] // All non-numeric
public void FilterPackagesToDelete_WithInvalidSemanticVersions_ShouldSkip(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow },
new() { Id = 2, Name = "test", Version = "2.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Invalid version should be skipped, only valid semantic version (id=2) is processed
Assert.NotNull(result);
// Should not crash and should only consider the valid version
Assert.DoesNotContain(result, p => p.Id == 2); // Valid prod should not be deleted
}
[Theory]
[InlineData("101.0.0.0")]
[InlineData("200.5.3.100")]
[InlineData("1000.0.0.0")]
public void FilterPackagesToDelete_WithLargeMajorVersion_ShouldTreatAsDateVersion(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Large major versions (>100) are detected as date versions, not semantic
// These will fail date validation (invalid month/day) and be skipped
Assert.NotNull(result);
}
#endregion
#region Date Version Detection Tests
[Theory]
[InlineData("2024.1.1.1")]
[InlineData("2025.2.14.1")]
[InlineData("2026.12.31.999")]
[InlineData("2000.6.15.100")]
[InlineData("1999.1.1.1")]
public void FilterPackagesToDelete_WithValidDateVersions_ShouldProcess(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should process without throwing and not delete prod date versions
Assert.NotNull(result);
Assert.DoesNotContain(result, p => p.Id == 1); // Prod date version should not be deleted
}
[Theory]
[InlineData("2025.1.1")] // 3 components (missing build)
[InlineData("2025.1.1.1.1")] // 5 components
[InlineData("2025.13.1.1")] // Month out of range
[InlineData("2025.0.1.1")] // Month zero
[InlineData("2025.2.32.1")] // Day out of range
[InlineData("2025.2.0.1")] // Day zero
[InlineData("999.2.14.1")] // Year too small
[InlineData("3000.2.14.1")] // Year too large
[InlineData("2025.a.14.1")] // Non-numeric month
public void FilterPackagesToDelete_WithInvalidDateVersions_ShouldSkip(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow },
new() { Id = 2, Name = "test", Version = "1.0.0.0", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Invalid date version should be skipped, valid semantic version (id=2) is processed as prod
Assert.NotNull(result);
Assert.DoesNotContain(result, p => p.Id == 2); // Valid semantic prod should not be deleted
}
[Theory]
[InlineData("1000.1.1.1")] // Minimum valid year
[InlineData("2999.12.31.999")] // Maximum valid year
[InlineData("2025.1.1.1")] // January 1
[InlineData("2025.12.31.1")] // December 31
public void FilterPackagesToDelete_WithDateVersionBoundaries_ShouldProcess(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Boundary date versions should be recognized as valid
Assert.NotNull(result);
Assert.DoesNotContain(result, p => p.Id == 1); // Prod date version should not be deleted
}
#endregion
#region Case Sensitivity Tests
[Theory]
[InlineData("1.0.0-alpha")]
[InlineData("1.0.0-ALPHA")]
[InlineData("1.0.0-Alpha")]
[InlineData("1.0.0-AlPhA")]
public void FilterPackagesToDelete_WithDifferentCasePrerelease_ShouldHandleCorrectly(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - All case variations should be recognized as prerelease
Assert.NotNull(result);
Assert.Empty(result); // Single prerelease should be kept
}
[Theory]
[InlineData("1.0.0-dev")]
[InlineData("1.0.0-DEV")]
[InlineData("1.0.0-Dev")]
[InlineData("1.0.0-DeV")]
public void FilterPackagesToDelete_WithDifferentCaseDev_ShouldHandleCorrectly(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - All case variations should be recognized as dev version
Assert.NotNull(result);
Assert.Empty(result); // Single dev version should be kept
}
#endregion
#region Suffix/Identifier Tests
[Theory]
[InlineData("1.0.0-alpha1")]
[InlineData("1.0.0-alpha.1")]
[InlineData("1.0.0-beta2")]
[InlineData("1.0.0-rc.1")]
[InlineData("2025.2.14.1-dev.1")]
[InlineData("2025.2.14.1-dev123")]
public void FilterPackagesToDelete_WithCompoundSuffixes_ShouldIdentifyCorrectly(string version)
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = version, Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Compound suffixes should be recognized and not cause errors
Assert.NotNull(result);
Assert.Empty(result); // Single prerelease/dev should be kept
}
#endregion
#region Empty and Null Tests
[Fact]
public void FilterPackagesToDelete_WithEmptyList_ShouldReturnEmpty()
{
// Arrange
var packages = new List<GiteaPackage>();
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Empty input should return empty result
Assert.NotNull(result);
Assert.Empty(result);
}
[Fact]
public void FilterPackagesToDelete_WithNullableInputs_ShouldHandleGracefully()
{
// Arrange
var packages = new List<GiteaPackage>
{
new() { Id = 1, Name = "test", Version = "1.0.0", Type = "docker", CreatedAt = DateTime.UtcNow }
};
// Act
var result = _packageService.FilterPackagesToDelete(packages);
// Assert - Should handle without throwing and not delete prod
Assert.NotNull(result);
Assert.Empty(result); // Prod should not be deleted
}
#endregion
}

26
sh.actions.package-cleanup.Tests/sh.actions.package-cleanup.Tests.csproj Normal file
View File

@@ -0,0 +1,26 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<IsTestProject>true</IsTestProject>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<RootNamespace>sh.actions.package_cleanup.Tests</RootNamespace>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Include="xunit" Version="2.9.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Moq" Version="4.20.70" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="../sh.actions.package-cleanup/sh.actions.package-cleanup.csproj" />
</ItemGroup>
</Project>